Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove outgoingmessage _headers and _headersList #57551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

http: remove outgoingmessage _headers and _headersList #57551

wants to merge 1 commit into from
+4 −141

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Mar 20, 2025 •
edited
Loading

These have been deprecated for a long time.

cc @nodejs/tsc

@anonrig anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 20, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Mar 20, 2025
@anonrig anonrig force-pushed the yagiz/end-of-life-outgoingmessage branch 2 times, most recently from d1d7885 to 2412ec5 Compare March 20, 2025 00:54
@anonrig anonrig requested review from mcollina and jasnell March 20, 2025 00:54
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (6b42554) to head (e121734).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57551      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185000   184955      -45     
  Branches    36240    36234       -6     
==========================================
- Hits       166926   166918       -8     
+ Misses      11020    11005      -15     
+ Partials     7054     7032      -22
Files with missing lines Coverage Δ
lib/_http_outgoing.js 95.76% <ø> (+0.51%) ⬆️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas
Copy link
Member

Do we know how much this would impact? In the modules maintained by Express, I haven't seen us use this.

Could we run citgm here?

@anonrig anonrig added the needs-citgm PRs that need a CITGM CI run. label Mar 20, 2025
@Flarna Flarna added the deprecations Issues and PRs related to deprecations. label Mar 20, 2025
@anonrig anonrig force-pushed the yagiz/end-of-life-outgoingmessage branch from 2412ec5 to e121734 Compare March 20, 2025 19:22
jasnell
jasnell approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but definitely want @mcollina and @nodejs/http opinions

@aduh95
Copy link
Contributor

aduh95 commented Mar 20, 2025

CITGM(main): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3565/
CITGM(this PR): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3568/

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65858/

marco-ippolito
marco-ippolito approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig
Copy link
Member Author

anonrig commented Mar 24, 2025

cc @nodejs/tsc i recommend landing this pull-request to main so it can be in v24. the failing test in windows is a flaky test. any issues with manually landing this pull-request?

@mcollina
Copy link
Member

@anonrig unfortunately it didn't make the cut for v24.x (see #57057), it'll go in v25.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@ronag ronag ronag approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@Flarna Flarna Flarna approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.