Skip to content

Commit

Permalink
crimson/osd: use discard_result() in stop()
Browse files Browse the repository at this point in the history
we don't care about the result of shutdown() of messengers, when
shutting down the daemon actually, and we don't handle the failures.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed Jun 24, 2021
1 parent 9145d9c commit 20e02b0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/crimson/osd/osd.cc
Original file line number Diff line number Diff line change
Expand Up @@ -507,9 +507,7 @@ seastar::future<> OSD::stop()
}).then([this] {
return when_all_succeed(
public_msgr->shutdown(),
cluster_msgr->shutdown());
}).then_unpack([] {
return seastar::now();
cluster_msgr->shutdown()).discard_result();
}).handle_exception([](auto ep) {
logger().error("error while stopping osd: {}", ep);
});
Expand Down

0 comments on commit 20e02b0

Please sign in to comment.