gui: fix crash in Oscilloscope when selecting the Trigger B

A crash occured when Trigger B was selected, but the channel B was not enabled.
nooploop · Aug 30, 2024 · 84b0192 · 84b0192
1 parent c3b9da0
commit 84b0192
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/piejam_libs/gui/include/piejam/gui/model/StreamProcessor.h b/piejam_libs/gui/include/piejam/gui/model/StreamProcessor.h
@@ -73,14 +73,6 @@ struct StreamProcessor
         }
     }
 
-    void drop(std::size_t const frames)
-    {
-        for (auto&& processor : processors)
-        {
-            processor->drop(frames);
-        }
-    }
-
     void clear()
     {
         for (auto&& processor : processors)

diff --git a/piejam_libs/gui/src/piejam/gui/model/ScopeDataGenerator.cpp b/piejam_libs/gui/src/piejam/gui/model/ScopeDataGenerator.cpp
@@ -25,8 +25,6 @@ namespace piejam::gui::model
 namespace
 {
 
-using ScopeSamples = std::span<float const>;
-
 struct Args
 {
     std::size_t resolution{1};
@@ -165,6 +163,11 @@ findTrigger(
         TriggerSlope const trigger,
         float triggerLevel) -> ScopeData::Samples::iterator
 {
+    if (samples.empty())
+    {
+        return samples.end();
+    }
+
     BOOST_ASSERT(samples.size() >= windowSize);
 
     auto itFirst = samples.begin();