Skip to content

Commit

Permalink
qa/workunits/windows: alter python default argument types
Browse files Browse the repository at this point in the history
Found using mypy 1.1.1.

Signed-off-by: John Mulligan <[email protected]>
  • Loading branch information
phlogistonjohn committed Jan 24, 2024
1 parent d6af577 commit 1b5a12b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions qa/workunits/windows/test_rbd_wnbd.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
class CephTestException(Exception):
msg_fmt = "An exception has been encountered."

def __init__(self, message: str = None, **kwargs):
def __init__(self, message: str = '', **kwargs):
self.kwargs = kwargs
if not message:
message = self.msg_fmt % kwargs
Expand Down Expand Up @@ -520,7 +520,7 @@ def cleanup(self):
@classmethod
def print_results(cls,
title: str = "Test results",
description: str = None):
description: str = ''):
pass


Expand Down Expand Up @@ -551,7 +551,7 @@ class RbdFioTest(RbdTest):

def __init__(self,
*args,
fio_size_mb: int = None,
fio_size_mb: int = 0,
iterations: int = 1,
workers: int = 1,
bs: str = "2M",
Expand Down Expand Up @@ -603,7 +603,7 @@ def _get_fio_path(self):
return self.image.path

@Tracer.trace
def _run_fio(self, fio_size_mb=None):
def _run_fio(self, fio_size_mb: int = 0) -> None:
LOG.info("Starting FIO test.")
cmd = [
"fio", "--thread", "--output-format=json",
Expand All @@ -628,7 +628,7 @@ def run(self):
@classmethod
def print_results(cls,
title: str = "Benchmark results",
description: str = None):
description: str = ''):
if description:
title = "%s (%s)" % (title, description)

Expand Down

0 comments on commit 1b5a12b

Please sign in to comment.