Do not check for NULL before calling free()

nre-ableton · May 30, 2023 · 8e87196 · 8e87196
1 parent 203c03a
commit 8e87196
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/src/filter/curves/curves.c b/src/filter/curves/curves.c
@@ -274,10 +274,10 @@ f0r_instance_t f0r_construct(unsigned int width, unsigned int height)
 void f0r_destruct(f0r_instance_t instance)
 {
   curves_instance_t* inst = (curves_instance_t*)instance;
-  if (inst->bspline)   free(inst->bspline);
-  if(inst->bsplineMap) free(inst->bsplineMap);
-  if(inst->csplineMap) free(inst->csplineMap);
-  if(inst->curveMap)   free(inst->curveMap);
+  free(inst->bspline);
+  free(inst->bsplineMap);
+  free(inst->csplineMap);
+  free(inst->curveMap);
   free(inst);
 }
 

diff --git a/src/filter/delaygrab/delaygrab.cpp b/src/filter/delaygrab/delaygrab.cpp
@@ -131,7 +131,7 @@ DelayGrab::DelayGrab(int wdt, int hgt) {
 }
 
 DelayGrab::~DelayGrab() {
-  if(delaymap) free(delaymap);
+  free(delaymap);
   free(imagequeue);
 }
 
@@ -271,7 +271,7 @@ void DelayGrab::set_blocksize(int bs) {
   delaymapheight = (geo.h)/blocksize;
   delaymapsize = delaymapheight*delaymapwidth;
 
-  if(delaymap) { free(delaymap); delaymap = NULL; }
+  free(delaymap);
   delaymap = malloc(delaymapsize*4);
 
   createDelaymap(current_mode);

diff --git a/src/filter/nervous/nervous.cpp b/src/filter/nervous/nervous.cpp
@@ -99,7 +99,7 @@ Nervous::Nervous(int wdt, int hgt) {
 }
 
 Nervous::~Nervous() {
-  if(buffer) free(buffer);
+  free(buffer);
 }
 
 void Nervous::_init(int wdt, int hgt) {

diff --git a/src/filter/vertigo/vertigo.c b/src/filter/vertigo/vertigo.c
@@ -121,11 +121,7 @@ f0r_instance_t f0r_construct(unsigned int width, unsigned int height)
 void f0r_destruct(f0r_instance_t instance)
 {
   vertigo_instance_t* inst = (vertigo_instance_t*)instance;
-  if(inst->buffer!=NULL) 
-  {
-    free(inst->buffer); 
-    inst->buffer = NULL; 
-  }
+  free(inst->buffer); 
   free(instance);
 }