fix(Playout): infinite AdLib Items' timeline objects are not denowified (SOFIE-3665)

[jstarpl]

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

Some timeline objects are not denowified, because they don't match the expected geometry of the deNowifyCurrentPieces function. Because of this, starting Infinite Pieces via AdLibs is unreliable in terms of device state changes taking effect.

The issue can be discovered via a log message starting with:

Some timeline objects have unexpected now times!

New Behavior

deNowifyCurrentPieces collects timeline objects that can't be denowified by it and a second pass is done in deNowifyInfinites after updatePlannedTimingsForPieceInstances runs that will do a recursive search through the timelineObjs to calculate the appropriate enable.start value.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

• This PR affects the playout logic in general.

Time Frame

• This Bug Fix is critical for us, please review and merge it as soon as possible.

Other Information

Co-authored-by: Johan Nyman [email protected]

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 13.15789% with 66 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (13f0556) to head (5469a1a).
Report is 98 commits behind head on release51.

Files with missing lines	Patch %	Lines
...s/job-worker/src/playout/timeline/multi-gateway.ts	13.15%	66 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release51    #1382      +/-   ##
=============================================
- Coverage      58.09%   57.96%   -0.13%     
=============================================
  Files            525      525              
  Lines          85094    85292     +198     
  Branches        4599     4457     -142     
=============================================
+ Hits           49432    49439       +7     
- Misses         35631    35830     +199     
+ Partials          31       23       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.