[BitArray] Fix description implementation; update tests

nroberson · Feb 1, 2024 · ae641c3 · ae641c3
1 parent e01391e
commit ae641c3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/Sources/BitCollections/BitArray/BitArray+Descriptions.swift b/Sources/BitCollections/BitArray/BitArray+Descriptions.swift
@@ -17,10 +17,10 @@ extension UInt8 {
   internal static var _ascii1: Self { 49 }
 
   @inline(__always)
-  internal static var _asciiLT: Self { 49 }
+  internal static var _asciiLT: Self { 60 }
 
   @inline(__always)
-  internal static var _asciiGT: Self { 49 }
+  internal static var _asciiGT: Self { 62 }
 }
 
 extension BitArray: CustomStringConvertible {
@@ -62,15 +62,15 @@ extension BitArray {
     var result: String
     if #available(macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0, *) {
       result = String(unsafeUninitializedCapacity: self.count + 2) { target in
-        target.initializeElement(at: count - 1, to: ._asciiGT)
-        var i = count - 2
+        target.initializeElement(at: count + 1, to: ._asciiGT)
+        var i = count
         for v in self {
           target.initializeElement(at: i, to: v ? ._ascii1 : ._ascii0)
           i &-= 1
         }
         assert(i == 0)
         target.initializeElement(at: 0, to: ._asciiLT)
-        return count
+        return count + 2
       }
     } else {
       result = "<"

diff --git a/Tests/BitCollectionsTests/BitArrayTests.swift b/Tests/BitCollectionsTests/BitArrayTests.swift
@@ -959,24 +959,24 @@ final class BitArrayTests: CollectionTestCase {
 
   func test_description() {
     let a: BitArray = []
-    expectEqual("\(a)", "")
+    expectEqual("\(a)", "<>")
 
     let b: BitArray = [true, false, true, true, true]
-    expectEqual("\(b)", "11101")
+    expectEqual("\(b)", "<11101>")
 
     let c: BitArray = [false, false, false, false, true, true, true, false]
-    expectEqual("\(c)", "01110000")
+    expectEqual("\(c)", "<01110000>")
   }
 
   func test_debugDescription() {
     let a: BitArray = []
-    expectEqual("\(String(reflecting: a))", "[]")
+    expectEqual("\(String(reflecting: a))", "<>")
 
     let b: BitArray = [true, false, true, true, true]
-    expectEqual("\(String(reflecting: b))", "11101")
+    expectEqual("\(String(reflecting: b))", "<11101>")
 
     let c: BitArray = [false, false, false, false, true, true, true, false]
-    expectEqual("\(String(reflecting: c))", "01110000")
+    expectEqual("\(String(reflecting: c))", "<01110000>")
   }
 
   func test_mirror() {