Skip to content

Commit

Permalink
Apply the suggestions from @Ash258
Browse files Browse the repository at this point in the history
  • Loading branch information
sinloss committed Jun 9, 2020
1 parent 3188115 commit 91ea657
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions bin/uninstall.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ function do_uninstall($app, $global) {
# directory.
$refdir = unlink_current (appdir $app $global)

env_rm_path $manifest $refdir $global
env_rm $manifest $global
env_rm_path $manifest $refdir $global $architecture
env_rm $manifest $global $architecture

$appdir = appdir $app $global
try {
Expand Down
2 changes: 1 addition & 1 deletion libexec/scoop-reset.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ $apps | ForEach-Object {
create_shims $manifest $dir $global $architecture
create_startmenu_shortcuts $manifest $dir $global $architecture
env_add_path $manifest $dir $global $architecture
env_set $manifest $dir $global
env_set $manifest $dir $global $architecture
# unlink all potential old link before re-persisting
unlink_persist_data $original_dir
persist_data $manifest $original_dir $persist_dir
Expand Down
4 changes: 2 additions & 2 deletions libexec/scoop-uninstall.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ if (!$apps) { exit 0 }

uninstall_psmodule $manifest $refdir $global

env_rm_path $manifest $refdir $global
env_rm $manifest $global
env_rm_path $manifest $refdir $global $architecture
env_rm $manifest $global $architecture

try {
# unlink all potential old link before doing recursive Remove-Item
Expand Down
4 changes: 2 additions & 2 deletions libexec/scoop-update.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,8 @@ function update($app, $global, $quiet = $false, $independent, $suggested, $use_c
write-host "Uninstalling '$app' ($old_version)"
run_uninstaller $old_manifest $architecture $dir
rm_shims $old_manifest $global $architecture
env_rm_path $old_manifest $dir $global
env_rm $old_manifest $global
env_rm_path $old_manifest $dir $global $architecture
env_rm $old_manifest $global $architecture

# If a junction was used during install, that will have been used
# as the reference directory. Otherwise it will just be the version
Expand Down

0 comments on commit 91ea657

Please sign in to comment.