Skip to content

Commit

Permalink
Avoid -Wmissing-include-dirs warnings
Browse files Browse the repository at this point in the history
Only c2000 even uses this include path anymore, so we can remove it for
everything else.
  • Loading branch information
thetic committed Apr 23, 2024
1 parent 49bae19 commit 3f9ec0c
Show file tree
Hide file tree
Showing 14 changed files with 24 additions and 23 deletions.
4 changes: 2 additions & 2 deletions CppUTest.vcproj
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<Tool
Name="VCCLCompilerTool"
Optimization="0"
AdditionalIncludeDirectories=".\include\Platforms\VisualCpp,.\include"
AdditionalIncludeDirectories=".\include"
PreprocessorDefinitions="WIN32;_DEBUG;_LIB;STDC_WANT_SECURE_LIB;CPPUTEST_USE_LONG_LONG"
BasicRuntimeChecks="3"
RuntimeLibrary="3"
Expand Down Expand Up @@ -112,7 +112,7 @@
Name="VCCLCompilerTool"
Optimization="0"
InlineFunctionExpansion="1"
AdditionalIncludeDirectories=".\include\Platforms\VisualCpp,.\include"
AdditionalIncludeDirectories=".\include"
PreprocessorDefinitions="WIN32;NDEBUG;_LIB;STDC_WANT_SECURE_LIB;CPPUTEST_USE_LONG_LONG"
StringPooling="true"
RuntimeLibrary="0"
Expand Down
8 changes: 4 additions & 4 deletions CppUTest.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<ClCompile>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>.\include;.\include\Platforms\VisualCpp;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>.\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>_LIB;WIN32;_DEBUG;STDC_WANT_SECURE_LIB;CPPUTEST_USE_LONG_LONG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
<RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
Expand Down Expand Up @@ -106,7 +106,7 @@
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<ClCompile>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>.\include;.\include\Platforms\VisualCpp;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>.\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>_LIB;WIN32;_DEBUG;STDC_WANT_SECURE_LIB;CPPUTEST_USE_LONG_LONG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
<RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
Expand Down Expand Up @@ -138,7 +138,7 @@
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<ClCompile>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>.\include;.\include\Platforms\VisualCpp;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>.\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<InlineFunctionExpansion>OnlyExplicitInline</InlineFunctionExpansion>
<PreprocessorDefinitions>WIN32;NDEBUG;_LIB;STDC_WANT_SECURE_LIB;CPPUTEST_USE_LONG_LONG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down Expand Up @@ -173,7 +173,7 @@
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<ClCompile>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>.\include;.\include\Platforms\VisualCpp;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>.\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<InlineFunctionExpansion>OnlyExplicitInline</InlineFunctionExpansion>
<PreprocessorDefinitions>WIN32;NDEBUG;_LIB;STDC_WANT_SECURE_LIB;CPPUTEST_USE_LONG_LONG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<StringPooling>true</StringPooling>
Expand Down
2 changes: 1 addition & 1 deletion build/alltests.mmp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ TARGET cpputest.exe
TARGETTYPE exe
UID 0x00000000 0x03A6305A

USERINCLUDE ..\include ..\include\CppUTest ..\include\Platforms\Symbian ..\tests
USERINCLUDE ..\include ..\include\CppUTest ..\tests
SYSTEMINCLUDE \epoc32\include \epoc32\include\stdapis

STATICLIBRARY libcrt0.lib
Expand Down
2 changes: 1 addition & 1 deletion build/cpputest.mmp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ TARGET cpputest.lib
TARGETTYPE LIB
UID 0x00000000 0x03A6305A

USERINCLUDE ..\include ..\include\CppUTest ..\include\Platforms\Symbian
USERINCLUDE ..\include ..\include\CppUTest
SYSTEMINCLUDE \epoc32\include \epoc32\include\stdapis

SOURCEPATH ..\src\CppUTest
Expand Down
1 change: 1 addition & 0 deletions cmake/warnings.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ if(
-Wswitch-enum
-Wconversion
-Wsign-conversion
-Wmissing-include-dirs
-Wno-padded
-Wno-disabled-macro-expansion
-Wno-reserved-id-macro
Expand Down
4 changes: 2 additions & 2 deletions examples/AllTests/AllTests.vcproj
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<Tool
Name="VCCLCompilerTool"
Optimization="2"
AdditionalIncludeDirectories="../../include,../../include/Platforms/VisualCpp,../ApplicationLib"
AdditionalIncludeDirectories="../../include,../ApplicationLib"
PreprocessorDefinitions="WIN32;NDEBUG;_CONSOLE"
BasicRuntimeChecks="0"
RuntimeLibrary="3"
Expand Down Expand Up @@ -140,7 +140,7 @@
<Tool
Name="VCCLCompilerTool"
Optimization="0"
AdditionalIncludeDirectories="../../include,../../include/Platforms/VisualCpp,../ApplicationLib"
AdditionalIncludeDirectories="../../include,../ApplicationLib"
PreprocessorDefinitions="WIN32;_DEBUG;_CONSOLE"
BasicRuntimeChecks="3"
RuntimeLibrary="3"
Expand Down
4 changes: 2 additions & 2 deletions examples/ApplicationLib/ApplicationLib.vcproj
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<Tool
Name="VCCLCompilerTool"
Optimization="0"
AdditionalIncludeDirectories="../../include,../../include/Platforms/VisualCpp"
AdditionalIncludeDirectories="../../include"
PreprocessorDefinitions="WIN32;_DEBUG;_LIB"
BasicRuntimeChecks="3"
RuntimeLibrary="3"
Expand Down Expand Up @@ -116,7 +116,7 @@
<Tool
Name="VCCLCompilerTool"
Optimization="2"
AdditionalIncludeDirectories="../../include,../../include/Platforms/VisualCpp"
AdditionalIncludeDirectories="../../include"
PreprocessorDefinitions="WIN32;NDEBUG;_LIB"
BasicRuntimeChecks="0"
RuntimeLibrary="3"
Expand Down
1 change: 0 additions & 1 deletion platforms/Dos/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ COMMONFLAGS := \
-q -c -os -oc -d0 -we -w=3 -ml -zm \
-dCPPUTEST_MEM_LEAK_DETECTION_DISABLED=1 -dCPPUTEST_STD_CPP_LIB_DISABLED=1 \
-i$(call convert_paths,$(CPPUTEST_HOME)/include) \
-i$(call convert_paths,$(CPPUTEST_HOME)/include/Platforms/Dos) \
-i$(call convert_paths,$(WATCOM)/h) -i$(call convert_paths,$(WATCOM)/h/nt) \

# Disable W303 unreferenced parameter - PUNUSED is GNU-specific
Expand Down
1 change: 0 additions & 1 deletion platforms/armcc/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ COMPONENT_NAME := CppUTest

INCLUDE_DIRS :=\
$(CPPUTEST_HOME)/include \
$(CPPUTEST_HOME)/include/Platforms/armcc \

# armcc system include path
SYS_INCLUDE_DIRS:=$(KEIL_DIR)/include
Expand Down
4 changes: 2 additions & 2 deletions scripts/VS2010Templates/CppUTest_VS2010.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ImportGroup Label="PropertySheets" />
<PropertyGroup Label="UserMacros">
<CPPUTEST_INCLUDE_PATHS>$(CPPUTEST_HOME)\include;$(CPPUTEST_HOME)\include\CppUTestExt\CppUTestGTest;$(CPPUTEST_HOME)\include\CppUTestExt\CppUTestGMock;$(CPPUTEST_HOME)\include\Platforms\VisualCpp</CPPUTEST_INCLUDE_PATHS>
<CPPUTEST_INCLUDE_PATHS>$(CPPUTEST_HOME)\include;$(CPPUTEST_HOME)\include\CppUTestExt\CppUTestGTest;$(CPPUTEST_HOME)\include\CppUTestExt\CppUTestGMock</CPPUTEST_INCLUDE_PATHS>
<CPPUTEST_LIB_PATHS>$(CPPUTEST_HOME)\lib</CPPUTEST_LIB_PATHS>
<CPPUTEST_FORCED_INCLUDES>$(CPPUTEST_HOME)\include\Platforms\VisualCpp\Platform.h;$(CPPUTEST_HOME)\include\CppUTest\MemoryLeakDetectorMallocMacros.h;</CPPUTEST_FORCED_INCLUDES>
<CPPUTEST_FORCED_INCLUDES>$(CPPUTEST_HOME)\include\CppUTest\MemoryLeakDetectorMallocMacros.h;</CPPUTEST_FORCED_INCLUDES>
<CPPUTEST_LIB_DEPENDENCIES>CppUTest.lib</CPPUTEST_LIB_DEPENDENCIES>
</PropertyGroup>
<PropertyGroup />
Expand Down
1 change: 0 additions & 1 deletion scripts/templates/ProjectTemplate/ProjectMakefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ INCLUDE_DIRS =\
include \
include/* \
$(CPPUTEST_HOME)/include/ \
$(CPPUTEST_HOME)/include/Platforms/Gcc\
mocks

CPPUTEST_WARNINGFLAGS = -Wall -Werror -Wswitch-default
Expand Down
5 changes: 4 additions & 1 deletion src/CppUTest/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,12 @@ if(CPPUTEST_PLATFORM)
PRIVATE
${CMAKE_CURRENT_LIST_DIR}/../Platforms/${CPPUTEST_PLATFORM}/UtestPlatform.cpp
)
endif()

if(CPPUTEST_PLATFORM STREQUAL "c2000")
target_include_directories(CppUTest
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/../../include/Platforms/${CPPUTEST_PLATFORM}>
$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/../../include/Platforms/c2000>
)
endif()

Expand Down
4 changes: 2 additions & 2 deletions tests/AllTests.vcproj
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
Name="VCCLCompilerTool"
Optimization="0"
InlineFunctionExpansion="1"
AdditionalIncludeDirectories="..\include,..\include\Platforms\VisualCpp"
AdditionalIncludeDirectories="..\include"
PreprocessorDefinitions="WIN32;NDEBUG;_CONSOLE;CPPUTEST_USE_LONG_LONG"
StringPooling="true"
RuntimeLibrary="0"
Expand Down Expand Up @@ -129,7 +129,7 @@
<Tool
Name="VCCLCompilerTool"
Optimization="0"
AdditionalIncludeDirectories="..\include,..\include\Platforms\VisualCpp"
AdditionalIncludeDirectories="..\include"
PreprocessorDefinitions="_CONSOLE;WIN32;_DEBUG;CPPUTEST_USE_LONG_LONG"
BasicRuntimeChecks="3"
RuntimeLibrary="3"
Expand Down
6 changes: 3 additions & 3 deletions tests/AllTests.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
<FunctionLevelLinking>true</FunctionLevelLinking>
<WarningLevel>Level3</WarningLevel>
<SuppressStartupBanner>true</SuppressStartupBanner>
<AdditionalIncludeDirectories>..\include;..\include\CppUTestExt\CppUTestGTest;..\include\CppUTestExt\CppUTestGMock;..\include\Platforms\VisualCpp;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>..\include;..\include\CppUTestExt\CppUTestGTest;..\include\CppUTestExt\CppUTestGMock;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<DebugInformationFormat>OldStyle</DebugInformationFormat>
<TreatWarningAsError>true</TreatWarningAsError>
</ClCompile>
Expand Down Expand Up @@ -131,7 +131,7 @@
<FunctionLevelLinking>true</FunctionLevelLinking>
<WarningLevel>Level3</WarningLevel>
<SuppressStartupBanner>true</SuppressStartupBanner>
<AdditionalIncludeDirectories>..\include;..\include\CppUTestExt\CppUTestGTest;..\include\CppUTestExt\CppUTestGMock;..\include\Platforms\VisualCpp;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>..\include;..\include\CppUTestExt\CppUTestGTest;..\include\CppUTestExt\CppUTestGMock;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<DebugInformationFormat>OldStyle</DebugInformationFormat>
<TreatWarningAsError>true</TreatWarningAsError>
</ClCompile>
Expand Down Expand Up @@ -162,7 +162,7 @@
</Midl>
<ClCompile>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>..\include;..\include\CppUTestExt\CppUTestGTest;..\include\CppUTestExt\CppUTestGMock;..\include\Platforms\VisualCpp;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>..\include;..\include\CppUTestExt\CppUTestGTest;..\include\CppUTestExt\CppUTestGMock;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>_CONSOLE;WIN32;_DEBUG;CPPUTEST_USE_LONG_LONG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
<RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
Expand Down

0 comments on commit 3f9ec0c

Please sign in to comment.