-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance time range selector for metrics - include presets #2292
Conversation
Signed-off-by: adarsh0728 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
=======================================
Coverage 65.85% 65.86%
=======================================
Files 346 346
Lines 42801 42801
=======================================
+ Hits 28186 28190 +4
+ Misses 13542 13535 -7
- Partials 1073 1076 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: adarsh0728 <[email protected]>
We were using https://mui.com/x/react-date-pickers but for presets (last 1 hr, last 30mins etc) https://mui.com/x/react-date-pickers/shortcuts/ requires proversion (date and time shortcuts). Testing out different libraries and their outputs. |
Component Used: https://github.com/dangrossman/daterangepicker |
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Why is the date format so weird? |
@whynowy: talking about the attached date format? It's the default format for date with times. I tried with other formats but didn't work. Will check once more if there's a workaround. https://mui.com/x/react-date-pickers/date-time-range-field/ here, it's like What do you suggest? |
Is it according to different client? What i see in the link you posted is like below. |
…rom mui Signed-off-by: adarsh0728 <[email protected]>
@whynowy: yes it was a different component (for reference i added, but we aren't using that). I have made the changes and format would be like below. This works? |
Resolves #2278