Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance time range selector for metrics - include presets #2292

Merged
merged 9 commits into from
Dec 25, 2024

Conversation

adarsh0728
Copy link
Contributor

Resolves #2278

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.86%. Comparing base (dfae989) to head (42ecb2d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2292   +/-   ##
=======================================
  Coverage   65.85%   65.86%           
=======================================
  Files         346      346           
  Lines       42801    42801           
=======================================
+ Hits        28186    28190    +4     
+ Misses      13542    13535    -7     
- Partials     1073     1076    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adarsh0728
Copy link
Contributor Author

adarsh0728 commented Dec 18, 2024

We were using https://mui.com/x/react-date-pickers but for presets (last 1 hr, last 30mins etc) https://mui.com/x/react-date-pickers/shortcuts/ requires proversion (date and time shortcuts). Testing out different libraries and their outputs.
Will add the screenshots.

@adarsh0728 adarsh0728 changed the title Enhance time range selector for metrics feat: enhance time range selector for metrics - include presets Dec 19, 2024
@adarsh0728
Copy link
Contributor Author

adarsh0728 commented Dec 19, 2024

Component Used: https://github.com/dangrossman/daterangepicker

Screenshot 2024-12-19 at 5 26 02 PM Screenshot 2024-12-19 at 5 27 09 PM Screenshot 2024-12-19 at 5 28 05 PM

@adarsh0728 adarsh0728 marked this pull request as ready for review December 19, 2024 12:27
@whynowy
Copy link
Member

whynowy commented Dec 19, 2024

Why is the date format so weird?

@adarsh0728
Copy link
Contributor Author

adarsh0728 commented Dec 19, 2024

Why is the date format so weird?

@whynowy: talking about the attached date format? It's the default format for date with times. I tried with other formats but didn't work. Will check once more if there's a workaround.

https://mui.com/x/react-date-pickers/date-time-range-field/

here, it's like 04/17/2022 03:30 PM – 04/21/2022 06:30 PM

Screenshot 2024-12-19 at 10 43 00 PM Screenshot 2024-12-19 at 10 43 40 PM

What do you suggest?

@whynowy
Copy link
Member

whynowy commented Dec 19, 2024

Why is the date format so weird?

@whynowy: talking about the attached date format? It's the default format for date with times. I tried with other formats but didn't work. Will check once more if there's a workaround.

https://mui.com/x/react-date-pickers/date-time-range-field/

here, it's like 04/17/2022 03:30 PM – 04/21/2022 06:30 PM

Screenshot 2024-12-19 at 10 43 00 PM Screenshot 2024-12-19 at 10 43 40 PM
What do you suggest?

Is it according to different client? What i see in the link you posted is like below.

Screenshot 2024-12-19 at 9 55 19 AM

@adarsh0728
Copy link
Contributor Author

@whynowy: yes it was a different component (for reference i added, but we aren't using that).

I have made the changes and format would be like below. This works?
Screenshot 2024-12-20 at 8 00 44 AM

@whynowy whynowy merged commit d387d3f into numaproj:main Dec 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance the time range selector for metrics
2 participants