Skip to content

Commit

Permalink
Fix: provide changes according to QA (openware#283)
Browse files Browse the repository at this point in the history
* Fix: accoount activity list pagination
* Fix: profile verification container not scrollable
* Fix: deposit-history pagination visible
* Fix: handle disabled user otp
* Fix: change expired session modal styles
* Fix: add mobile web alerts
* Fix: change delete api key button color
* Fix: sign-in/registration modals visability imporvment
* Fix: change modal height styles
* Fix: change wallet action buttons styles
* Fix: add beneficiaries fetch on update
* Fix: change basic color theme to dark
* Fix: cancel button added for input in CurrenMarketInfo component
* Fix: change filter input clear
* Fix: add wallet banner on withdraw screen
* Fix: num pad for price/amount fields on Trading page
* Feature: dropdown insted of tabs for orders and charts headers
* Fix: change dropdown style names
* Feature: remove toolbars from Trading view for mobile devices
* Fix: polish mobile chart styles
* Feature: add order input action buttons
* Feature: add order price input action buttons
* Fix: add check for finex enabled to price filters
* Fix: change error message styles
* Fix: add check for existing price filters
* Fix: clear user data from alert error
* Fix: change ob styles and depth fetch hook
* Fix: change search field icon
* Fix: add orders pagination
* Fix: change search icon indentation
* Fix: remove arrows from order input
* Fix: change KYC upload image styles

Co-authored-by: Kohelbekker <[email protected]>
  • Loading branch information
oyershov and Kohelbekker committed Nov 19, 2020
1 parent a9dd546 commit 89cc4c7
Show file tree
Hide file tree
Showing 69 changed files with 877 additions and 202 deletions.
26 changes: 0 additions & 26 deletions mocks/api/v2/peatio/market/orders/GET.mock
Original file line number Diff line number Diff line change
Expand Up @@ -18,31 +18,5 @@ Access-Control-Allow-Credentials: true
"remaining_volume":"123.1234",
"executed_volume":"50",
"trades_count":0
},
{ "id":16,
"side":"sell",
"ord_type":"limit",
"price":"0.3",
"avg_price":"0.4",
"state":"wait",
"market":"ethbtc",
"created_at":"2018-11-20T10:24:48+01:00",
"origin_volume":"123.1234",
"remaining_volume":"123.1234",
"executed_volume":"0.0",
"trades_count":0
},
{ "id":162,
"side":"buy",
"ord_type":"market",
"price":"0.1",
"avg_price":"0.4",
"state":"wait",
"market":"btczar",
"created_at":"2018-11-09T13:21:55+01:00",
"origin_volume":"123.1234",
"remaining_volume":"123.1234",
"executed_volume":"0.0",
"trades_count":0
}
]
6 changes: 5 additions & 1 deletion public/css/tradingview.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
html.theme-dark .chart-page {
background-color: var(--body-background-color);
}

html.theme-dark .group-wWM3zP_M- {
background-color: var(--trading-view-background);
background-color: transparent;
}
1 change: 1 addition & 0 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const RenderDeviceContainers = () => {
return (
<div className="pg-mobile-app">
<MobileHeader />
<AlertsContainer/>
<LayoutContainer/>
<MobileFooter />
</div>
Expand Down
14 changes: 14 additions & 0 deletions src/assets/images/SearchFieldCloseIcon.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import * as React from 'react';

interface SearchFieldCloseIconProps {
className?: string;
onClick?: (e?: any) => void;
}

export const SearchFieldCloseIcon: React.FC<SearchFieldCloseIconProps> = (props: SearchFieldCloseIconProps) => {
return (
<svg className={props.className} onClick={props.onClick} width="15" height="15" viewBox="0 0 15 15" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M7.5 0C11.6475 0 15 3.3525 15 7.5C15 11.6475 11.6475 15 7.5 15C3.3525 15 0 11.6475 0 7.5C0 3.3525 3.3525 0 7.5 0ZM10.1925 3.75L7.5 6.4425L4.8075 3.75L3.75 4.8075L6.4425 7.5L3.75 10.1925L4.8075 11.25L7.5 8.5575L10.1925 11.25L11.25 10.1925L8.5575 7.5L11.25 4.8075L10.1925 3.75Z" fill="var(--icons)"/>
</svg>
);
};
12 changes: 12 additions & 0 deletions src/components/CustomInput/CustomInput.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,15 @@
transition: background-color 5000s ease-in-out 0s;
}
}

.pg-mobile-app .custom-input {
font-size: 12px;

input {
font-size: 14px;

&::placeholder {
font-size: 14px;
}
}
}
65 changes: 62 additions & 3 deletions src/components/Dropdown/Dropdown.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
position: relative;

.show > .btn-primary.dropdown-toggle {
border: 1px solid var(--input-border-color-active) !important;
border: 1px solid var(--input-border-color-active);
box-shadow: none !important;
color: var(--dropdown-text-color-active) !important;

Expand Down Expand Up @@ -32,9 +32,9 @@

&:focus,
&:active {
border: 1px solid var(--input-border-color-active) !important;
border: 1px solid var(--input-border-color-active);
box-shadow: none !important;
color: var(--dropdown-text-color-active) !important;
color: var(--dropdown-text-color-active);
}

&::after {
Expand Down Expand Up @@ -76,4 +76,63 @@
}
}
}

&--mobile {
height: 34px;

.show > .btn-primary.dropdown-toggle {
border: 0;
color: var(--primary-cta-color);
}

.dropdown {
&-toggle,
&-toggle:focus,
&-toggle:active {
border: 0;
color: var(--primary-cta-color);
height: 34px;
}

&-toggle {
background: var(--tab-panel-background-color) !important;
color: var(--primary-cta-color);
display: flex;
font-size: 14px;
justify-content: flex-start;
min-width: 60px;
padding: 5px 8px;

.cr-dropdown__arrow {
padding-left: 5px;
position: initial;

path {
fill: var(--primary-cta-color);
}
}
}

.dropdown-menu {
border-radius: 4px;
min-width: 0;
top: -32px !important;

.dropdown-item {
align-items: center;
border-radius: 4px;
display: flex;
font-size: 14px;
height: 36px;
justify-content: flex-start;
padding: 0 12px;

&:nth-child(1) {
background: var(--primary-cta-color);
border-radius: 4px 4px 0 0;
}
}
}
}
}
}
27 changes: 27 additions & 0 deletions src/components/EmailForm/EmailForm.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,30 @@
}
}
}

@media screen and (max-width: 767px), (max-height: 599px) {
.cr-email-form {
background: unset;
margin: 0 auto;
}

.cr-email-form__form-content {
background: var(--body-background-color);
position: static;
}

.cr-email-form__button-wrapper {
position: static;

button {
font-size: 14px;
height: 41px;
text-transform: uppercase;
}
}

.cr-email-form__group--focused input:focus {
border-color: var(--button-primary-cta-background-color);
border-width: 2px;
}
}
2 changes: 1 addition & 1 deletion src/components/EmailForm/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const EmailForm = React.memo((props: EmailFormProps) => {
handleFocusInput={props.handleFieldFocus}
classNameLabel="cr-email-form__label"
classNameInput="cr-email-form__input"
autoFocus={true}
autoFocus={!isMobileDevice}
/>
{emailError && <div className="cr-email-form__error">{emailError}</div>}
</div>
Expand Down
6 changes: 6 additions & 0 deletions src/components/ExpiredSessionModal/ExpiredSessionModal.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,9 @@
}
}
}

@media screen and (max-width: 767px), (max-height: 599px) {
.expired-session-modal .cr-modal .cr-email-form__button-wrapper {
padding: 0 14px;
}
}
8 changes: 6 additions & 2 deletions src/components/FilterInput/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import classnames from 'classnames';
import * as React from 'react';
import { SearchFieldCloseIcon } from '../../assets/images/SearchFieldCloseIcon';
import SearchIcon from './Search.svg';

interface OnChangeEvent {
Expand Down Expand Up @@ -48,8 +49,8 @@ export class FilterInput extends React.Component<FilterInputProps, SearchInputSt
this.filterList = this.filterList.bind(this);
}

public filterList(event: OnChangeEvent) {
const value = event.target.value;
public filterList(event?: OnChangeEvent) {
const value = event ? event.target.value : '';
const { data, filter } = this.props;

const result = data
Expand All @@ -76,6 +77,9 @@ export class FilterInput extends React.Component<FilterInputProps, SearchInputSt
placeholder={placeholder ? placeholder : 'Search'}
onChange={this.filterList}
/>
<span className="cr-search__cancel">
<SearchFieldCloseIcon onClick={e => this.filterList()} />
</span>
</div>
);
}
Expand Down
18 changes: 9 additions & 9 deletions src/components/MarketDepths/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export interface MarketDepthsProps {
gradientHide?: boolean;
/**
* Current color theme mode
* @default 'basic'
* @default 'dark'
*/
colorTheme?: string;
}
Expand Down Expand Up @@ -138,14 +138,14 @@ const getColorSettings = (colorTheme?: string) => {
}

return {
strokeAreaAskColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.strokeAreaAsk)),
strokeAreaBidColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.strokeAreaBid)),
strokeAxisColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.strokeAxis)),
strokeGridColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.strokeGrid)),
fillAreaAskColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.fillAreaAsk)),
fillAreaBidColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.fillAreaBid)),
gridBackgroundStartColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.gridBackgroundStart)),
gridBackgroundEndColor: convertRgbToHex(getStylesValueByKey(colors.basic.depth.gridBackgroundEnd)),
strokeAreaAskColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.strokeAreaAsk)),
strokeAreaBidColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.strokeAreaBid)),
strokeAxisColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.strokeAxis)),
strokeGridColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.strokeGrid)),
fillAreaAskColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.fillAreaAsk)),
fillAreaBidColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.fillAreaBid)),
gridBackgroundStartColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.gridBackgroundStart)),
gridBackgroundEndColor: convertRgbToHex(getStylesValueByKey(colors.dark.depth.gridBackgroundEnd)),
};
};

Expand Down
3 changes: 3 additions & 0 deletions src/components/Order/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export interface OrderComponentProps {
* default tab index
*/
defaultTabIndex?: number;
isMobileDevice?: boolean;
currentMarketFilters: FilterPrice[];
translate: (id: string, value?: any) => string;
}
Expand Down Expand Up @@ -179,6 +180,7 @@ export class Order extends React.Component<OrderComponentProps, State> {
asks,
bids,
currentMarketFilters,
isMobileDevice,
listenInputPrice,
translate,
} = this.props;
Expand Down Expand Up @@ -217,6 +219,7 @@ export class Order extends React.Component<OrderComponentProps, State> {
handleAmountChange={this.handleAmountChange}
handleChangeAmountByButton={this.handleChangeAmountByButton}
currentMarketFilters={currentMarketFilters}
isMobileDevice={isMobileDevice}
translate={translate}
/>
),
Expand Down
6 changes: 4 additions & 2 deletions src/components/OrderForm/OrderForm.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
display: flex;
flex-direction: row;
font-size: 12px;
height: 24px;
margin-top: 80px;
height: 0;
margin-top: 68px;
opacity: 0;
padding: 0 14px;
position: fixed;
Expand All @@ -24,6 +24,8 @@
z-index: 10;

&--visible {
height: 24px;
margin-top: 80px;
opacity: 1;
}
}
Expand Down
Loading

0 comments on commit 89cc4c7

Please sign in to comment.