-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cui Minjing] iP #13
Open
Cuiminjing
wants to merge
59
commits into
nus-cs2113-AY2122S1:master
Choose a base branch
from
Cuiminjing:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Cui Minjing] iP #13
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
4caa62c
level-0
Cuiminjing 22361f2
Update Duke.java
Cuiminjing d9444d5
Merge remote-tracking branch 'origin/master'
Cuiminjing 5a95fff
Level-1
Cuiminjing 9082346
Level-1
Cuiminjing f9d3e52
Level-2
Cuiminjing 035821c
Level-3
Cuiminjing 44ec76d
Level-4
Cuiminjing b1b1d94
Level-4
Cuiminjing 24b02c7
Level-4
Cuiminjing e497d25
Level-4 final with ui
Cuiminjing 2222f06
level-4 after peer review
Cuiminjing 633befa
Level-5
Cuiminjing e7c8ad4
exception
Cuiminjing c2637d1
package
Cuiminjing 7caaf87
commit
Cuiminjing 5052722
for branch level 5
Cuiminjing fe3aae2
for master
Cuiminjing 78c0a19
for master
Cuiminjing 8f91ee9
practice
Cuiminjing c6ae5c3
..
Cuiminjing 2a818e7
level-6
Cuiminjing 548867c
for master
Cuiminjing dc40ec5
level-7
Cuiminjing aa415ce
level-9
Cuiminjing 7970bad
Level-9 final
Cuiminjing b07d5d1
JavaDoc
Cuiminjing fcf82ba
Update README.md
Cuiminjing 09b6898
Update README.md
Cuiminjing bf3ba61
Update README.md
Cuiminjing eb1a1b4
Update README.md
Cuiminjing 912736e
Update README.md
Cuiminjing b84167c
Update README.md
Cuiminjing c90176d
no message
Cuiminjing a06dec1
Merge remote-tracking branch 'origin/master'
Cuiminjing c039eb1
images
Cuiminjing 1cde7f8
Update README.md
Cuiminjing 3798107
Update README.md
Cuiminjing 1d7f2da
Update README.md
Cuiminjing 2e7fc7d
Update README.md
Cuiminjing ac11498
Update README.md
Cuiminjing 46bfe80
Update README.md
Cuiminjing bf17d78
Update README.md
Cuiminjing 4c56f42
Update README.md
Cuiminjing d0fbb00
Update README.md
Cuiminjing 05d765d
Update README.md
Cuiminjing 338ef72
final
Cuiminjing 59ebc42
add error detecting
Cuiminjing c521047
Update README.md
Cuiminjing b5314f1
Update README.md
Cuiminjing 5c06be4
Update README.md
Cuiminjing 7f3abf0
Update README.md
Cuiminjing 82aaf0f
Update README.md
Cuiminjing 10f2a4a
test
Cuiminjing 9080cae
Merge pull request #1 from Cuiminjing/branch-A-JavaDoc
Cuiminjing 12ecb0d
final version of ip
Cuiminjing 4b632a0
Merge branch 'branch-A-JavaDoc'
Cuiminjing 93acc4c
Merge remote-tracking branch 'origin/master'
Cuiminjing 8a4135c
change for ug
Cuiminjing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Level-4
- Loading branch information
commit 24b02c7f38b49768c622c62ee74d615d1853f879
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,63 @@ | ||
Hello from | ||
____ _ | ||
| _ \ _ _| | _____ | ||
____ _ | ||
| _ \ _ _| | _____ | ||
| | | | | | | |/ / _ \ | ||
| |_| | |_| | < __/ | ||
|____/ \__,_|_|\_\___| | ||
|
||
____________________________________________________________ | ||
Hello! I'm Duke | ||
What can I do for you? | ||
____________________________________________________________ | ||
todo task1 | ||
____________________________________________________________ | ||
Got it. I've added this task: | ||
[T][ ] task1 | ||
Now you have 1 tasks in the list | ||
____________________________________________________________ | ||
todo taks2 | ||
____________________________________________________________ | ||
Got it. I've added this task: | ||
[T][ ] taks2 | ||
Now you have 2 tasks in the list | ||
____________________________________________________________ | ||
|
||
____________________________________________________________ | ||
Here are the tasks in your list: | ||
1.[T][ ] task1 | ||
2.[T][ ] taks2 | ||
____________________________________________________________ | ||
|
||
____________________________________________________________ | ||
Nice! I've marked this task as done: | ||
[T][X] task1 | ||
____________________________________________________________ | ||
|
||
____________________________________________________________ | ||
Got it. I've added this task: | ||
[D][ ] task3 (y Sunday) | ||
Now you have 3 tasks in the list | ||
____________________________________________________________ | ||
|
||
____________________________________________________________ | ||
Got it. I've added this task: | ||
[E][ ] task4 (t 2-3pm) | ||
Now you have 4 tasks in the list | ||
____________________________________________________________ | ||
|
||
____________________________________________________________ | ||
Nice! I've marked this task as done: | ||
[E][X] task4 (at: t 2-3pm) | ||
____________________________________________________________ | ||
|
||
____________________________________________________________ | ||
Here are the tasks in your list: | ||
1.[T][X] task1 | ||
2.[T][ ] taks2 | ||
3.[D][ ] task3 (by: y Sunday) | ||
4.[E][X] task4 (at: t 2-3pm) | ||
____________________________________________________________ | ||
|
||
____________________________________________________________ | ||
Bye. Hope to see you again soon! | ||
____________________________________________________________ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
todo task1 | ||
todo task2 | ||
list | ||
done 1 | ||
deadline task3 /by Sunday | ||
event task4 /at 2-3pm | ||
done 4 | ||
list | ||
bye |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation for this method is quite long. Perhaps it could be refactored further? For example, the handling of each task (todo / deadline / event) could be made different methods. You may also consider making the "happy path" more prominent.