fix(module): regression add module not updating nuxt.config

[BobbieGoede]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Had a feeling this was not (fully) working, and was reminded to check it out when the functionality was mentioned during the ecosystem meeting 😅

Fixes a regression possibly introduced in #208, it seems like it has gone unreported all this time:

If a module had to be installed as dependency, it would exit before updating the nuxt.config. Since we're checking if addDependency returns true while it's a void function (see https://github.com/nuxt/cli/blob/main/packages/nuxi/src/commands/module/add.ts#L148).

Not sure why we're not using try...catch blocks, this fix simply adds a .then(() => true) in the interest of keeping changes small/consistent (but also because I'm not sure how to trigger/test the catch case 🤭).

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@717

npm i https://pkg.pr.new/nuxi@717

npm i https://pkg.pr.new/@nuxt/cli@717

commit: 5b74d4c

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ee87c27). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage        ?   13.54%           
=======================================
  Files           ?       66           
  Lines           ?     3351           
  Branches        ?       96           
=======================================
  Hits            ?      454           
  Misses          ?     2866           
  Partials        ?       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.