Update translations from l10n #17262
Conversation
From translation svn revision: 83941 Authors: Zahari Yurukov <[email protected]> Kostadin Kolev <[email protected]> Stats: 2 2 source/locale/bg/symbols.dic 341 316 user_docs/bg/changes.md 2 files changed, 343 insertions(+), 318 deletions(-)
From translation svn revision: 83941 Authors: Nikola Jovic <[email protected]> Janko Valencik <[email protected]> Zvonimir <[email protected]> Danijela Popovic <[email protected]> Stats: 2 2 source/locale/sr/symbols.dic 1 file changed, 2 insertions(+), 2 deletions(-)
From translation svn revision: 83952 Authors: Bram Duvigneau <[email protected]> Bart Simons <[email protected]> A Campen <[email protected]> Leonard de Ruijter <[email protected]> Stats: 43 51 source/locale/nl/symbols.dic 1 file changed, 43 insertions(+), 51 deletions(-)
WalkthroughThis pull request introduces comprehensive updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
source/locale/bg/symbols.dic (1)
Line range hint
108-109: Verify the mapping of single quotation marksThe single quotation marks are currently mapped as:
‘to "ляво ударение"’to "дясно ударение"Since
‘and’represent left and right single quotation marks, consider mapping them to "леви единични кавички" and "десни единични кавички" respectively for clarity.‘ леви единични кавички ’ десни единични кавичкиsource/locale/nl/symbols.dic (1)
188-190: Standardize division symbol descriptionsThe division symbols
⁄and÷have different descriptions:
⁄is mapped togedeeld door÷is mapped todelen doorTo maintain consistency and avoid confusion, consider using the same description for both symbols, unless there is a specific reason for the distinction.
Apply this suggestion to unify the descriptions:
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (3)
- source/locale/bg/symbols.dic (2 hunks)
- source/locale/nl/symbols.dic (13 hunks)
- source/locale/sr/symbols.dic (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
source/locale/bg/symbols.dic (1)
Pattern
**/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious. When providing code suggestions, particularly when requested, ensure GitHub's suggestion format is used, i.e.:suggestion <code changes>source/locale/nl/symbols.dic (1)
Pattern
**/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious. When providing code suggestions, particularly when requested, ensure GitHub's suggestion format is used, i.e.:suggestion <code changes>source/locale/sr/symbols.dic (1)
Pattern
**/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious. When providing code suggestions, particularly when requested, ensure GitHub's suggestion format is used, i.e.:suggestion <code changes>
🔇 Additional comments (5)
source/locale/nl/symbols.dic (4)
22-23: Ensure consistency in thousands separator representationThe term
puntis used as the replacement forthousands separator. Sincepuntcan mean both 'point' and 'period' in Dutch, ensure that this does not cause confusion with the decimal point (kommain Dutch).Consider clarifying the replacement text if necessary.
184-184: Updated multiplication symbol description improves clarityThe symbol
×now has the descriptionmaal, which accurately represents multiplication in Dutch. This change enhances user understanding.
219-219: Confirm the accuracy of mathematical term for '≈'The symbol
≈is described asbijna gelijk aan('almost equal to'). Ensure that this term is the standard mathematical expression used in Dutch for this symbol.
9-11: Verify the correctness of the updated regular expressionsThe regular expressions for
decimal point,thousands separator, andbegin-word 'have been updated. Please ensure that they correctly match the intended patterns for the Dutch locale:
decimal pointshould match commas used as decimal separators (e.g.,123,45).thousands separatorshould match periods used as thousands separators (e.g.,1.234).begin-word 'should match apostrophes at the beginning of words (e.g.,'tin't is waar).You can run the following script to test these regex patterns:
✅ Verification successful
Regular expressions for Dutch locale verified successfully
- All updated regular expressions for
decimal point,thousands separator, andbegin-word 'are functioning as intended.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Test the updated regular expressions for Dutch locale. # Test decimal point regex echo "Testing decimal point regex:" echo "Number: 123,45" | rg -o '(?<![^\d -])\,(?=\d)' # Test thousands separator regex echo "Testing thousands separator regex:" echo "Number: 1.234" | rg -o '(?<=\d)\.(?=\d{3})' # Test begin-word apostrophe regex echo "Testing begin-word apostrophe regex:" echo "Phrase: 't is waar" | rg -o "((?<=\s)|(?<=^))'(?=\w(\s|$|[-.,?!]))"Length of output: 1108
Script:
#!/bin/bash # Description: Test the updated regular expressions for Dutch locale with PCRE2 enabled. # Test decimal point regex echo "Testing decimal point regex:" echo "Number: 123,45" | rg --pcre2 -o '(?<![^\d -])\,(?=\d)' # Test thousands separator regex echo "Testing thousands separator regex:" echo "Number: 1.234" | rg --pcre2 -o '(?<=\d)\.(?=\d{3})' # Test begin-word apostrophe regex echo "Testing begin-word apostrophe regex:" echo "Phrase: 't is waar" | rg --pcre2 "((?<=\s)|(?<=^))'(?=\w(\s|$|[-.,?!]))"Length of output: 461
source/locale/sr/symbols.dic (1)
106-107: Symbols for single quotation marks added correctlyThe entries for the left and right single quotation marks (
‘and’) have been appropriately added with their Serbian translationslevi polunavodnikanddesni polunavodnik.
| „ леви кавички | ||
| ′ прим | ||
| ″ секонд | ||
| ‴ терц |
There was a problem hiding this comment.
Potential inconsistencies in prime symbol translations
The prime symbols are mapped as follows:
′to "прим"″to "секунд"‴to "терц"
While "прим" for ′ is appropriate, using "секунд" (which means "second") for ″ and "терц" (which can mean "third") for ‴ may cause confusion, especially if interpreted as units of time rather than mathematical notation.
Consider revising the translations to reflect their mathematical meaning to avoid ambiguity.
| “ десни кавички | ||
| ” десни кавички | ||
| ‘ ляво ударение | ||
| ’ дясно ударение |
There was a problem hiding this comment.
Incorrect mapping of double quotation marks
The symbols for double quotation marks are mapped as:
“mapped to "десни кавички"”mapped to "десни кавички"
However, “ is the LEFT DOUBLE QUOTATION MARK and should be mapped to "леви кавички" (left quotation marks). Mapping both symbols to "десни кавички" could lead to confusion in distinguishing opening and closing quotes.
Please apply the following correction:
| “ десни кавички | |
| ” десни кавички | |
| ‘ ляво ударение | |
| ’ дясно ударение | |
| “ леви кавички | |
| ” десни кавички |
Rebased nvaccess/nvda-l10n:beta on nvaccess/nvda:beta, dropping commits that didn't touch
source/locale, and editing commits that did but also toucheduser_docsto remove changes touser_docs.Summary by CodeRabbit
New Features
Bug Fixes
Documentation