Skip to content
This repository has been archived by the owner on Aug 29, 2022. It is now read-only.

Story/google analytics #48

Merged
merged 18 commits into from
Aug 2, 2021
Merged

Story/google analytics #48

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0dd78d6
initialized ga4 setup
ksiegel1923 Jul 27, 2021
97399e5
added google analytics events that track current page as the screen t…
ksiegel1923 Jul 27, 2021
313efed
moved google analytics so tracks for every page change not just if th…
ksiegel1923 Jul 28, 2021
c9d570a
moved GA functions from module and into separate file, added extra ev…
ksiegel1923 Jul 29, 2021
3289075
added google analytics event that tracks whether the module has come …
ksiegel1923 Jul 29, 2021
6c413d4
moved the useOnScreen hook into a hooks folder
ksiegel1923 Jul 30, 2021
a86cdcf
cleanup before PR
ksiegel1923 Jul 30, 2021
a1abfae
merged with dev before creating PR
ksiegel1923 Jul 30, 2021
086b739
altered ga info so only in English
ksiegel1923 Jul 30, 2021
c46c839
PR comments: changed googleAnalytics file to hook, changed variable n…
ksiegel1923 Jul 30, 2021
75ddf5a
fixed merge conflicts with dev
ksiegel1923 Jul 30, 2021
28e00ed
added arguments to pageChange and pageTitleAsScreen calls
ksiegel1923 Jul 30, 2021
7efcc45
PR comment: move moduleOnScreen to googleAnalytics hook
ksiegel1923 Jul 30, 2021
f43c905
only initialize ga4react with a gaid once (avoid problems with langua…
ksiegel1923 Jul 30, 2021
9085396
changed parameter of renderApp for language change
ksiegel1923 Jul 30, 2021
35aeb4c
moved initialize() out of renderApp so that it's only called once
michellexliu Jul 30, 2021
5d0a4db
resolved merge conflicts
michellexliu Jul 30, 2021
f03c4d8
bugfixes:
ksiegel1923 Aug 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added arguments to pageChange and pageTitleAsScreen calls
  • Loading branch information
@ksiegel1923
ksiegel1923 committed Jul 30, 2021
commit 28e00ed62bf30962e2487676403d0435bfb2eb7b
8 changes: 4 additions & 4 deletions feedback-module/src/components/Module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ function Module({ pagetitle, endpoint, dir }) {
focusFirstError();
} else {
updateOtherField();
pageTitleAsScreen;
pageChange;
pageTitleAsScreen(en(screen.title));
pageChange(en(screen.title), en(SCREENS[nextScreen].title));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be en(screen.title, { page: pagetitle }) (same for other one) bc of the string interpolation in our translation config.

sendFormData(screen.formID),
setScreen(SCREENS[nextScreen]),
setCheckboxError(false);
Expand All @@ -135,8 +135,8 @@ function Module({ pagetitle, endpoint, dir }) {
updateFeedbackForAPI(setFeedbackType, [en(text), feedbackID]);
setScreen(SCREENS[nextScreen]);
setCheckboxError(false);
pageTitleAsScreen;
pageChange;
pageTitleAsScreen(en(screen.title));
pageChange(en(screen.title), en(SCREENS[nextScreen].title));
}

headerRef.current.scrollIntoView(true);
Expand Down
2 changes: 1 addition & 1 deletion feedback-module/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const renderApp = (Div, lang, pagetitle, endpoint, gaid) => {
const ga4react = new GA4React(gaid);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to create a new GA4React object every time the app is re-rendered (i.e. could we put this line outside of the renderApp function)? Not too familiar with how GA4React works, so I'm just wondering.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we are getting the gaid attribute within the render app which is why I put this here. I guess we could make the assumption that the user won't change their gaid so we wouldn't need to observe for it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm that's a good point— I guess we can keep it how it is just in case?

(async () => {
await ga4react
.initialize({ send_page_view: false })
.initialize()
.then((res) => console.log(`Analytics Success: ${res} ${gaid}`))
.catch((err) => console.log(`Analytics Failure: ${err}`))
.finally(() => {
Expand Down