refactor: use encodeURIComponent

oanhgle · Aug 9, 2021 · ede5f3d · ede5f3d
1 parent ffd3515
commit ede5f3d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/public/index.html b/src/public/index.html
@@ -89,7 +89,7 @@ <h3 class="animated animated-text">
                             <button class="btn mr-lg-2 custom-btn"
                                 onclick="tweet()"><span class="iconify" data-icon="uil-twitter-alt"
                                     data-inline="false"></span>&nbsp; Tweet </button>
-                            <button class="btn mr-lg-" class="btn custom-btn custom-btn-bg" onclick="getRandom()">New quote</button>
+                            <button class="btn custom-btn custom-btn-bg" class="btn custom-btn custom-btn-bg" onclick="getRandom()">New quote</button>
                         </div>
                     </div>
                 </div>

diff --git a/src/public/js/app.js b/src/public/js/app.js
@@ -1,9 +1,13 @@
+/* share on twitter */
 function tweet() {
   const quote = document.getElementById("quote").innerHTML;
   const author = document.getElementById("author").innerHTML;
   const info = document.getElementById("info").innerHTML;
+  const fullText = `${quote} - ${author} (${info})`;
   window.open(
-    `https://twitter.com/intent/tweet?text=${quote} - ${author} (${info})&hashtags=BTSQUOTESAPI`
+    `https://twitter.com/intent/tweet?text=${encodeURIComponent(
+      fullText
+    )}&hashtags=BTSQUOTESAPI`
   );
 }
 
@@ -15,13 +19,7 @@ function getRandom() {
       document.getElementById("quote").innerHTML = data.quote;
       document.getElementById("author").innerHTML = data.member;
       console.log(data.quote + " - " + data.member); //for debugging
-
       getInfo(data.quote);
-
-      //share on twitter
-      document.getElementById("shareOnTW").href =
-        "http://twitter.com/intent/tweet/?text=" +
-        encodeURIComponent(data.quote + " - " + data.member);
     })
     .catch((err) => console.log(err));
 }