fix: merlin and private_modules #6405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When private modules are enabled, only the public cmi directory was passed to merlin. The end result is that all .cmt and .cmti files were hidden causing a degraded experience. We fix this by providing the private dir to merlin. Signed-off-by: Rudi Grinberg <[email protected]> ps-id: dc5a051b-ca65-48cf-a63f-8a61128b2cf2
|
Won't doing this "desynchronize" Merlin and the compiler ? If Merlin has access to the |
|
Ah that's annoying. I guess we'll need to copy the .cmt and .cmtis to a separate folder after all. Removed the 3.6.0 milestone as this is a bit harder. |
|
@rgrinberg do you have a fix for 3.7 or should we clear the milestone? |
|
I'll clear the milestone this is is unlikely to get in 3.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When private modules are enabled, only the public cmi directory was
passed to merlin. The end result is that all .cmt and .cmti files were
hidden causing a degraded experience. We fix this by providing the
private dir to merlin.
Signed-off-by: Rudi Grinberg [email protected]
ps-id: dc5a051b-ca65-48cf-a63f-8a61128b2cf2