[Ctypes] fix compilation in byte-only #7431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: François Bobot <[email protected]>
bobot
force-pushed
the
fix_ctypes_in_byteonly
branch
from
5b12e24 to
8003e71
Compare
|
Could you add a test somehow? I think we we have an example of hiding ocamlopt to simulate a bytecode only switch. |
|
I can try. But a more general would be to add a byte-only variant in the general test matrix, no? |
|
There's a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the native compilation is not present, the compilation of the generators for ctypes fails since it only use native compilation. For example https://ocaml.ci.dev/github/bobot/ocaml-flint/commit/24ee67cb3939b936777d5f9899d558de3773816d/variant/debian-11-5.0_s390x_opam-2.1#L313-313
This fix is better than the current code, but perhaps we should use one of the compilation modes selected for the library.
CC @kit-ty-kate