Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): cannot replace original pl name where editing pl #4088

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

zijiacj
Copy link
Collaborator

@zijiacj zijiacj commented Dec 23, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

For the name FuN_tesT@111~! The #$%^&*()_+ function, which contains special regular expression characters, was recognized as a regular match using String.replaceFirst method, resulting in an uncompleted replacement.

Invalid the special characters of the regular expression contained in the function name, then use the replaceFirst method to complete the replacement

Which issue(s) this PR fixes:

Fixes #3941

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@zijiacj zijiacj added the type-bug Something isn't working label Dec 23, 2024
@zijiacj zijiacj added this to the ODC 4.3.3 milestone Dec 23, 2024
@zijiacj zijiacj self-assigned this Dec 23, 2024
@zijiacj zijiacj requested a review from guowl3 as a code owner December 24, 2024 09:32
Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@guowl3 guowl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guowl3 guowl3 merged commit 36fe6cc into dev/4.3.x Dec 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

3 participants