-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schedule):support common quartz schedule job #4092
Merged
guowl3
merged 4 commits into
dev/obcloud_24v5
from
feat/jingtian_support_quartz_normal_schedule_job
Dec 27, 2024
Merged
feat(schedule):support common quartz schedule job #4092
guowl3
merged 4 commits into
dev/obcloud_24v5
from
feat/jingtian_support_quartz_normal_schedule_job
Dec 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachThinking
force-pushed
the
feat/jingtian_support_quartz_normal_schedule_job
branch
from
December 23, 2024 11:11
6c0b870
to
84fbe5d
Compare
PeachThinking
force-pushed
the
feat/jingtian_support_quartz_normal_schedule_job
branch
from
December 24, 2024 02:37
84fbe5d
to
77d3cc5
Compare
guowl3
previously approved these changes
Dec 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LioRoger
reviewed
Dec 25, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/quartz/QuartzJobService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/quartz/QuartzJobService.java
Show resolved
Hide resolved
PeachThinking
requested review from
MarkPotato777,
yizhouxw and
LuckyPickleZZ
as code owners
December 25, 2024 09:11
LioRoger
reviewed
Dec 26, 2024
...r/odc-service/src/main/java/com/oceanbase/odc/service/quartz/config/QuartzConfiguration.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/quartz/QuartzJobServiceProxy.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/quartz/AbstractQuartzJobService.java
Outdated
Show resolved
Hide resolved
LioRoger
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
guowl3
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
module-quartz
What this PR does / why we need it:
support common quartz schedule job which is not related to ODC scheduled tasks.
common quartz job will use
commonScheduler
to schedule job.add
private Class<? extends Job> jobClass
inCreateQuartzJobParam
andChangeQuartJobParam
to determine whether to usecommonScheduler
ordefaultScheduler
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: