Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schedule):support common quartz schedule job #4092

Merged

Conversation

PeachThinking
Copy link
Collaborator

@PeachThinking PeachThinking commented Dec 23, 2024

What type of PR is this?

module-quartz

What this PR does / why we need it:

support common quartz schedule job which is not related to ODC scheduled tasks.
common quartz job will use commonScheduler to schedule job.
add private Class<? extends Job> jobClass in CreateQuartzJobParam and ChangeQuartJobParam to determine whether to use commonScheduler or defaultScheduler.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking self-assigned this Dec 23, 2024
@PeachThinking PeachThinking force-pushed the feat/jingtian_support_quartz_normal_schedule_job branch from 6c0b870 to 84fbe5d Compare December 23, 2024 11:11
@PeachThinking PeachThinking force-pushed the feat/jingtian_support_quartz_normal_schedule_job branch from 84fbe5d to 77d3cc5 Compare December 24, 2024 02:37
guowl3
guowl3 previously approved these changes Dec 25, 2024
Copy link
Collaborator

@guowl3 guowl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@LioRoger LioRoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@guowl3 guowl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guowl3 guowl3 merged commit 458177a into dev/obcloud_24v5 Dec 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants