imgui_te_utils: support emscripten / fix ImFileCreateDirectoryChain #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E_WCHAR32 We cannot use ImWchar, which can be 32bits if IMGUI_USE_WCHAR32 (and CreateDirectoryW require 16bits wchar).
pthom
changed the title
ocornut
added a commit
that referenced
this pull request
Apr 15, 2024
… build on missing CPU ifdefs (#35)
ocornut
pushed a commit
that referenced
this pull request
Apr 15, 2024
ocornut
pushed a commit
that referenced
this pull request
Apr 15, 2024
…WCHAR32 (#35) We cannot use ImWchar, which can be 32bits if IMGUI_USE_WCHAR32 (and CreateDirectoryW require 16bits wchar).
|
All merged, thank you Pascal. Sorry I sort of forgot about this simple PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Omar,
This PR contains small fixes:
(in which case
ImTextStrFromUtf8will produce a 32 bits text, which cannot be used by CreateDirectoryW)