Skip to content

Commit

Permalink
Fix double-translation tests
Browse files Browse the repository at this point in the history
- Copy files with expected output
- Remove duplicated env settings
- Do not run the test with wasm_of_ocaml, which does not support the
  double translation
  • Loading branch information
vouillon authored and hhugo committed Jan 25, 2025
1 parent 522972b commit e10af9e
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions compiler/tests-jsoo/lib-effects-2/dune
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
(env
(with-effects
(flags
(:standard -w -38))
(js_of_ocaml
(flags
(:standard --effects=double-translation))
;; separate compilation doesn't yet work when using
;; '--effect=double-translation' since Dune doesn't know it should compile a
;; different version of the dependencies.
;; TODO: remove once support in ocaml/dune#11222 is released.
(compilation_mode whole_program)))
(_
(flags
(:standard -w -38))
Expand All @@ -26,12 +15,16 @@
(only_sources true)
(files ../lib-effects/*.ml))

(copy_files
(only_sources true)
(files ../lib-effects/*.expected))

(library
(name jsoo_testsuite_effect2)
(enabled_if
(>= %{ocaml_version} 5))
(inline_tests
(modes js wasm best))
(modes js))
(modules
(:standard
\
Expand All @@ -48,7 +41,7 @@
(>= %{ocaml_version} 5))
(names effects)
(modules effects)
(modes js wasm))
(modes js))

(tests
(build_if
Expand Down

0 comments on commit e10af9e

Please sign in to comment.