-
Notifications
You must be signed in to change notification settings - Fork 118
[IMP] account: enable journal item search by amount #4814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0-rd-accounting-onboarding-malb
Are you sure you want to change the base?
[IMP] account: enable journal item search by amount #4814
Conversation
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr !
@@ -308,6 +308,7 @@ | |||
<field name="name"/> | |||
<field name="ref"/> | |||
<field name="invoice_date"/> | |||
<field name="move_id" string="Journal Item Amount" filter_domain="[('move_id.amount_total', '=', self)]"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really what i expected, look for the field debit and credit on the move lines
Also commit message don't follow the guidelines for the task-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you can see that you have 2 commits on the pr, squash them 😄 We usually work with only one commit 😄
also still need to check why the venv is there in the git ignore ahah, we will never merge that in production 👀
00406a4
to
414279a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the field could be other thing and still work, maybe it would make more sense to have the balance instead but it's ok in this context 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should be changed, should not mention the venv thing 😄
Improved the journal items search functionality by allowing users to find entries that match a specific debit or credit value. task-4908848
414279a
to
8d41cf4
Compare
Extended the journal items search view to allow searching by amount