[FIX] account: show delivery date on invoices for French companies #4820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Jul 9, 2025
|
|
||
| def _post(self, soft=True): | ||
| for move in self: | ||
| if move.country_code == 'FR' and move.is_sale_document() and not move.delivery_date: |
There was a problem hiding this comment.
use the field show_delivery_date instead of repeating the condition here 👀
| # EXTENDS 'account' | ||
| super()._compute_show_delivery_date() | ||
| for move in self: | ||
| if move.country_code == 'FR': |
There was a problem hiding this comment.
Instead of doing that, look why we have is_company_french, maybe you could use it instead 😄
shzi-odoo
force-pushed
the
18.0-rd-accounting-onboarding-shzi-invoice-delivery-date-fr
branch
from
67006a4 to
e12b21b
Compare
Fixed an issue where the delivery date was not displayed on invoices for companies operating in France when the interface language was set to French. The delivery date is now properly fixed. task-4908851
shzi-odoo
force-pushed
the
18.0-rd-accounting-onboarding-shzi-invoice-delivery-date-fr
branch
from
e12b21b to
8cfd3d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the delivery date was not displayed on invoices for companies operating in France when the interface language was set to French.
The delivery date is now properly fixed.
shzi
task-4908851