[ADD] Attendances: Reporting #13332
Open
[ADD] Attendances: Reporting #13332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @Felicious - this is ready for a peer review. |
Felicious
approved these changes
May 14, 2025
larm-odoo
force-pushed
the
18.0-attendances-reporting-larm
branch
from
011d8c7 to
f2ae90d
Compare
|
Hi @StraubCreative - this is ready for a final review. Thanks! |
|
We're also going to move this straight to technical review (: @samueljlieber ? |
samueljlieber
requested changes
May 16, 2025
There was a problem hiding this comment.
Hi @larm-odoo, off to a great start but I am requesting changes for the following reason:
Please update the media folder name to match the RST file name:
attendances/
attendance_reporting.rst
- reporting/
+ attendance_reporting/Be sure to update all image target paths used in the RST doc as well!
Tag me for another look once this has been addressed, the rest of the doc looks good to me :)
Note
Just a heads up, you may encounter a conflict when #13230 is merged, due to both PRs making edits to hr/attendances.rst.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new doc on reporting, and pulling it from the original main attendances doc.