[ADD] barcode: serial numbers and lots #13363
Conversation
slinkous
commented
May 14, 2025
slinkous
commented
- Coverage for printing and managing barcoders for product serial numbers and lot numbers
|
|
There was a problem hiding this comment.
@Felicious this is going to fail CI checks because it's not in the tree, but both my current PR's will go to the same place, so I just need to figure out which one of them gets approved first.
There was a problem hiding this comment.
Fantastic work with this doc, @slinkous!
It's a very comprehensive doc that covers a variety of use cases and considers many tedious tasks a warehouse user might face, including getting blocked when a shipping label is damaged during transit! That's something I would've never thought of! I can tell you did a lot of research from the master class and watching BE's OXP videos from the previous 2-3 years 😊
I just had some minor nitpicks on wording in this review, and it's ready to go to the next stage after looking through them!
In the case where there are merge conflicts (one will occur in setup.rst), we write in the PR description which one is meant to be merged first. After we merge the first PR, we'll rebase the second PR, resolve the merge conflicts, push the second PR back up, wait for the tests to finish, then merge the second!
After addressing my comments, let's just add the serial_numbers_lots.rst file to setup.rst, so the checks pass for the next reviewer (:
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
| the line for the product, and click the :icon:`fa-list` :guilabel:`(list)` icon. In the | ||
| :guilabel:`Open: Stock move` pop-up menu, click :guilabel:`Generate Serials/Lots`. | ||
|
|
||
| .. image:: serial_numbers_lots/serial-number-generate.png |
There was a problem hiding this comment.
we no longer use markup on images! is the blue rectangle something you added yourself, or something that shows up in the UI if you do something? o:
There was a problem hiding this comment.
Okay, so I didn't add it, but it's weird to reproduce how it happened... it appears sometimes after I have hovered the button...
There was a problem hiding this comment.
okie let's just leave the image alone! maybe it's a UI thing. I dont want to make you reproduce the image for a small thing, esp since it can technically happen
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
| To use serial numbers or lots, they must be enabled in the database and tracking by lot or serial | ||
| number must be selected for each product. See the :doc:`serial numbers documentation | ||
| <../../inventory/product_management/product_tracking/serial_numbers>` and :doc:`lots documentation | ||
| <../../inventory/product_management/product_tracking/lots>` to learn how to start using this | ||
| feature. |
There was a problem hiding this comment.
Again a nitpick, and just a suggestion, but im wondering if this would be better a numbered list
| To use serial numbers or lots, they must be enabled in the database and tracking by lot or serial | |
| number must be selected for each product. See the :doc:`serial numbers documentation | |
| <../../inventory/product_management/product_tracking/serial_numbers>` and :doc:`lots documentation | |
| <../../inventory/product_management/product_tracking/lots>` to learn how to start using this | |
| feature. | |
| To use lots or serial numbers: | |
| #. They must be enabled in the database. | |
| #. Tracking by lot or serial number must be selected for each product. | |
| See the :doc:`serial numbers documentation | |
| <../../inventory/product_management/product_tracking/serial_numbers>` and :doc:`lots documentation | |
| <../../inventory/product_management/product_tracking/lots>` to learn how to start using this | |
| feature. |
|
|
||
| To print a barcode for one or multiple product serial numbers and lots, go to | ||
| :menuselection:`Inventory app --> Products --> Lots / Serial Numbers`. In the list view, tick the | ||
| box for all the products to print, click the :icon:`fa-print` :guilabel:`Print` button, and select |
There was a problem hiding this comment.
| box for all the products to print, click the :icon:`fa-print` :guilabel:`Print` button, and select | |
| checkbox for each the product to print, click the :icon:`fa-print` :guilabel:`Print` button, and select |
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Show resolved
Hide resolved
| Operations | ||
| ========== | ||
|
|
||
| For any product that is tracked by serial number, performing an operation with barcode can be done |
There was a problem hiding this comment.
is it just serial numbers, or are lots included as well?
"Performing an operation with barcode" --> "Barcode"?
| To make it mandatory to scan a barcode for serial numbers and lots, go to :menuselection:`Inventory | ||
| app --> Configuration --> Operations Types` and select the operation type where barcodes should be | ||
| required for serial numbers. Then, click the :guilabel:`Barcode App` tab and in the |
There was a problem hiding this comment.
Unlike the GS1 configuration one, I think the instructions should go above the image (:
content/applications/inventory_and_mrp/barcode/setup/serial_numbers_lots.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
was there a particular reason why the instructions below are about enabling mandatory scan, but the image has optional scan highlighted? For consistency, it might be better for the image to match the instructions and the heading of the section
The instructions are about selecting the appropriate setting, it's just that the UI calls this Mandatory Scan. Renaming section to clairfy.
There was a problem hiding this comment.
was there a particular reason why the instructions below are about enabling mandatory scan, but the image has optional scan highlighted? For consistency, it might be better for the image to match the instructions and the heading of the section
The instructions are about selecting the appropriate setting, it's just that the UI calls this Mandatory Scan. Renaming section to clairfy.
slinkous
force-pushed
the
18.0-barcode-serials-lots-stul
branch
2 times, most recently
from
1f1d734 to
6aa08e9
Compare
Co-authored-by: Felicious <[email protected]>
slinkous
force-pushed
the
18.0-barcode-serials-lots-stul
branch
from
6aa08e9 to
9187b25
Compare
