Skip to content

[ADD] accounting/l10n_co: Add doc on automatic currency Colombia #13850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

masi-odoo
Copy link
Contributor

@masi-odoo masi-odoo commented Jun 26, 2025

Add documentation on the automatic currency rate for CO which is an integration with the "Banco de la Republica" service.

Drive with photos: https://drive.google.com/drive/folders/1jdPv6PNF_ekTuNxqw9GXoIJgII9HN-Eh?usp=sharing

@robodoo
Copy link
Collaborator

robodoo commented Jun 26, 2025

Pull request status dashboard

@masi-odoo masi-odoo requested a review from samueljlieber June 26, 2025 19:05
@samueljlieber samueljlieber requested review from StraubCreative and removed request for samueljlieber July 10, 2025 12:55
Add documentation on the automatic currency rate for CO which is an integration with the "Banco de la Republica" service.
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @masi-odoo

Thank you for your contribution.
Ideally for a PR this small we shouldn't see so many technical issues.

Please review the items below for next time:

  • Title tags for PRs like this should have the [IMP] tag not [ADD], since it's an improvement to existing documentation. [ADD] is reserved for brand new modules and files.
  • Commit messages are ideally 50 characters or less.
  • Headings need to have as many characters in the formatting line as in the heading itself.
  • Break lines in the RST to ideally not exceed more than 100 characters. You can break apart most RST directives like hyperlinks and menuselection tags across lines, wherever there's a space.

Thanks again and hope this helps!
I will push up all of the fixes and merge momentarily...

@@ -289,6 +289,16 @@ is based on the PUC (Plan Unico de Cuentas).

.. _localization/colombia/workflows:

Multicurrency
------------
The official exchange rate is provided by the `Banco de la República <https://suameca.banrep.gov.co/estadisticas-economicas/>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100-character line limit: you can break the link markup if there's a space.

Suggested change
The official exchange rate is provided by the `Banco de la República <https://suameca.banrep.gov.co/estadisticas-economicas/>`_.
The official exchange rate is provided by the `Banco de la República
<https://suameca.banrep.gov.co/estadisticas-economicas/>`_.

Comment on lines 295 to 296
Go to :menuselection:`Accounting --> Configuration --> Settings --> Currencies: Automatic Currency Rates`
to set an **Interval** for the exchange rate or select a different **service**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100-character line limit: similarly, you can break menuselection tags wherever here's a space.

Suggested change
Go to :menuselection:`Accounting --> Configuration --> Settings --> Currencies: Automatic Currency Rates`
to set an **Interval** for the exchange rate or select a different **service**.
Go to :menuselection:`Accounting --> Configuration --> Settings --> Currencies: Automatic Currency
Rates` to set an **Interval** for the exchange rate or select a different **service**.

Comment on lines 292 to 293
Multicurrency
------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title underline too short

Suggested change
Multicurrency
------------
Multicurrency
-------------

@StraubCreative
Copy link
Contributor

ci/minimal check is not passing because the branch name is not properly formatted (needs to start with Odoo version prefix e.g. 16.0, 17.0, 18.0, master so runbot can initiate).

Closing this PR and continuing over on #13967 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants