Skip to content

Conversation

jero-odoo
Copy link
Contributor

Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=4882474&access_token=6d6b342b-72de-48c0-a5e7-842222976069

Adding content for Subcontracting lead times and subcontracting portal.

@jero-odoo jero-odoo self-assigned this Sep 24, 2025
@robodoo
Copy link
Collaborator

robodoo commented Sep 24, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team September 24, 2025 15:34
@jero-odoo jero-odoo requested a review from larm-odoo September 24, 2025 15:36
@jero-odoo
Copy link
Contributor Author

Hey @larm-odoo this is ready for review. Thanks!

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo - great doc, all optional comments. Approved!

@jero-odoo jero-odoo force-pushed the 18.0-mrp-subcontracting-leadtimes-jero branch from 3841bfe to 13d4fa6 Compare September 25, 2025 15:30
@jero-odoo
Copy link
Contributor Author

Hey @Felicious this is ready for final/tech review. Thanks!

@jero-odoo jero-odoo requested a review from Felicious September 25, 2025 15:51
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo, thanks for tackling this very complex topic and incorporating the SME feedback! I especially appreciate the effort you put into summarizing all the lead times in a table at the end (: that really helps pull the concepts together

That said, there are still some significant areas to revisit. Lead times in subcontracting are tricky, and I think some of the misunderstandings here stem from gaps in the base knowledge of how manufacturing and purchase lead times actually work in this context. I completely understand that the original source material didn’t provide much clarity (and it’s possible even the original author didn’t fully grasp it), but this is where we add value as writers: giving readers the necessary context to understand why they’re configuring lead times a certain way, so they can map them to their own operations.

In my review, I’ve highlighted:

  • Reframing opportunities: Some definitions are correct but too generic; reframing them in subcontracting terms would make them much more useful.
  • Misunderstandings to correct: A few areas suggest a misinterpretation of how lead times behave. These will need rework, and I’m happy to revisit them together if helpful.
  • Context gaps: Some workflows (e.g., around security lead times) can’t be explained without setting up more prerequisite information. Without that context, the reader won’t be able to follow.
  • Missing angles: There are also some important features worth noting (like how PO deadlines are tied to lead times) that would strengthen this doc.

I’ve added detailed comments inline, but if you’d prefer, I’m happy to hop on a call to walk through the logic and examples together! My goal is to make sure the background around subcontracting and lead times feels clear and solid, so that future docs in this area are easier and more straightforward for you to tackle (:

Co-authored-by: larm-odoo <[email protected]>

Co-authored-by: Felicia Kuan <[email protected]>
@jero-odoo jero-odoo force-pushed the 18.0-mrp-subcontracting-leadtimes-jero branch from 49715bb to cc9b526 Compare September 30, 2025 20:19
@jero-odoo
Copy link
Contributor Author

Hi @Felicious I've made siginificant updates based on the feedback provided, this is ready for re-review. I have also reached out to the SME for additional insight.
Thank you

@jero-odoo jero-odoo requested a review from Felicious September 30, 2025 20:36
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo,

This revision improves the accuracy and clarity of the concepts. Two areas still need clarification: I’ve left comments in the MTO and Desk Combination sections.

Once those are addressed, re-tag me in review. I also recommend involving an inventory/manufacturing expert to confirm the details. Lead times are already complex, and we risk misleading readers if anything here is incorrect.

Comment on lines +105 to +109
The time it takes for the subcontractor to confirm they can accept the work (i.e., when they approve
the |RfQ| in Odoo).

The time needed to prepare the components that will be sent to the subcontractor, so they are ready
by the time production begins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of seems like these two items are bullet points?

convert it into a |PO|.

This is a general setting in Odoo, meaning only one value can be configured for the entire company.
It applies to all subcontracted products, but not to directly purchased products.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure it applies to both subcontracted and purchased products. Just curious whether Magdalena told you otherwise?

Comment on lines +120 to +129
In a subcontracting flow, products configured with |MTO| do not generate a Manufacturing Order in
Odoo. Instead, Odoo creates a |PO| to the subcontractor. The subcontractor's production is managed
outside of Odoo, but lead times are still important for scheduling.

- Manufacturing Lead Time: This field represents the subcontractor's production lead time (the time
the subcontractor needs to manufacture the product once they have all the necessary components).
- Manufacturing Security Lead Time: This setting applies **only** to in-house manufacturing. It does
not buffer subcontractor production. However, if a subcontracted product is used as a component in
an in-house Manufacturing Order, then manufacturing security lead time applies to that downstream
in-house process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading this, I still have a lingering question

My main confusion is: if no MO is created in this flow, how do these manufacturing lead times actually get applied? In other words, if we’re asking users to set manufacturing lead times for subcontracted products, how does the MTO process use that data to notify them about planning deadlines or scheduling constraints?

Could you clarify this point more explicitly in the doc? I think it'll be helpful for the readers!

Comment on lines +160 to +169
- Odoo schedules the PO for *Desk Combination* based on the 5-day component lead time.
- The |PO| is created **2 days earlier** than the calculated date due to the purchase security
lead time.
- The expected delivery date from the subcontractor is **3 days** after the |PO| date, reflecting
the subcontractor's vendor lead time.
- If *Desk Combination* is used in a downstream in-house |MO|, any additional manufacturing
security lead time would apply to that in-house operation.

This example shows how each lead time contributes to scheduling, rather than simply summing them
into a single customer lead time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jess, I still need some clarification here.

  1. On the BoM for Desk Combination:
  • Is Drawer Black purchased directly from a vendor to the company? (5 days)
  • Is [random component name] produced by a subcontractor and then sent to the company? (3 days)

Right now, the way the sentence is written—“how each lead time contributes to scheduling”—makes it sound like both items are components that need to be gathered at the company for in-house manufacturing. That isn’t clear in the text. Can you rewrite so the roles of each component are explicit?

  1. if in-house manufacturing is part of this example, why isn’t the manufacturing lead time mentioned?

  2. Finally, can you explain why we’re using this specific example to tie together all the lead times defined earlier? I’m not saying it’s the wrong choice, but I want to be sure the example actually verifies the reader’s understanding of all the lead times we’ve introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants