Skip to content

Conversation

theRealThagomizer
Copy link
Contributor

Big rework of the "Renew subscriptions" page

  • Added appropriate icons to all smart button guilabels
  • Removed unnecessary language from throughout
  • Reorganized content into more logical sections (e.g., all "See Also" sections moved to end and merged)
  • Reworked "Important" section at end with more accurate language, pending a rewrite of the "Scheduled actions" page
  • Cleaned up the RST, ensuring guilabels are used correctly
  • Cleaned up the RST, standardizing between bolding and italicizing for emphasis

This 18.0 PR can be FWP up to master.

Not sure if this reaches 50% revised, so I've marked it 2 points for now.

@robodoo
Copy link
Collaborator

robodoo commented Oct 2, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 2, 2025 23:40
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @theRealThagomizer!

Since this is a longer doc, I’m splitting my review into several passes so we can cover everything thoroughly.

In this round, I left comments on overall structure, plus a few minor formatting and style notes. Quick notes:

  • no need to capitalize Odoo terms like "renewal quotation" and "chatter" when we're referring to them. Unless we're specifically referring to the "Renewal Quotation" status on the sales order.
  • "sales order" rather than "sale order" as a singular term

I also have a question about scope: yesterday in the office we discussed moving the detailed instructions about how contracts in exception work (and the common pitfalls) into the Scheduled Actions doc. Is that still the plan? I want to make sure I understand whether we’re handling this across two PRs, with this one focused mainly on improving this doc.

If that’s the case, I’m curious why you modified the content in the important block instead of shortening it. Are you planning to move that content over in a follow-up PR? Knowing your plan will help me review more effectively. (:

Once you’ve addressed these comments, feel free to re-tag me for another review—it’s almost there!

Comment on lines 5 to 9
Subscription renewal is the process customers follow when they willingly choose to continue a
subscription product or service. Subscribers go through the renewal process at different intervals
-- weekly, monthly, annually, etc. -- depending on the duration of the agreed-upon contract. Most
companies that offer subscriptions prefer to automate the renewal process for customers. However,
manual subscription renewals are still used in some cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muchhh better rewrite!!!!

Comment on lines 37 to 30

.. image:: renewals/renew-button.png
:align: center
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t need to be updated for this PR, since the images are still accurate in version 18. But just for future reference: we’ve updated our style guidelines to stop using red boxes to mark up screenshots. For your next PRs, please take screenshots without them.

@theRealThagomizer theRealThagomizer added 3 and removed 2 labels Oct 3, 2025
@theRealThagomizer theRealThagomizer force-pushed the 18.0-subscriptions-renew-subscription-revisions-thjud branch from 01f832d to b6ad1e1 Compare October 3, 2025 23:02
@theRealThagomizer
Copy link
Contributor Author

@Felicious I made the earlier edits and adjusted the way the info is presented in the doc. I can also see that I didn't format the headings properly, so I've made a note to myself to fix that ASAP. -_-;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants