-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[IMP] Subscriptions: Renew subscriptions page rework #14768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[IMP] Subscriptions: Renew subscriptions page rework #14768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a longer doc, I’m splitting my review into several passes so we can cover everything thoroughly.
In this round, I left comments on overall structure, plus a few minor formatting and style notes. Quick notes:
- no need to capitalize Odoo terms like "renewal quotation" and "chatter" when we're referring to them. Unless we're specifically referring to the "Renewal Quotation" status on the sales order.
- "sales order" rather than "sale order" as a singular term
I also have a question about scope: yesterday in the office we discussed moving the detailed instructions about how contracts in exception work (and the common pitfalls) into the Scheduled Actions doc. Is that still the plan? I want to make sure I understand whether we’re handling this across two PRs, with this one focused mainly on improving this doc.
If that’s the case, I’m curious why you modified the content in the important block instead of shortening it. Are you planning to move that content over in a follow-up PR? Knowing your plan will help me review more effectively. (:
Once you’ve addressed these comments, feel free to re-tag me for another review—it’s almost there!
Subscription renewal is the process customers follow when they willingly choose to continue a | ||
subscription product or service. Subscribers go through the renewal process at different intervals | ||
-- weekly, monthly, annually, etc. -- depending on the duration of the agreed-upon contract. Most | ||
companies that offer subscriptions prefer to automate the renewal process for customers. However, | ||
manual subscription renewals are still used in some cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
muchhh better rewrite!!!!
|
||
.. image:: renewals/renew-button.png | ||
:align: center |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn’t need to be updated for this PR, since the images are still accurate in version 18. But just for future reference: we’ve updated our style guidelines to stop using red boxes to mark up screenshots. For your next PRs, please take screenshots without them.
Co-authored-by: Felicia Kuan <[email protected]>
01f832d
to
b6ad1e1
Compare
@Felicious I made the earlier edits and adjusted the way the info is presented in the doc. I can also see that I didn't format the headings properly, so I've made a note to myself to fix that ASAP. -_-; |
Big rework of the "Renew subscriptions" page
This 18.0 PR can be FWP up to master.
Not sure if this reaches 50% revised, so I've marked it 2 points for now.