Skip to content

Conversation

mial-odoo
Copy link
Contributor

Previous commits ended up with a little less info than intended so this PR adds two things:

Fixes the missing picture in #14582 And adds references to #14767

@robodoo
Copy link
Collaborator

robodoo commented Oct 8, 2025

Pull request status dashboard

@mial-odoo mial-odoo requested a review from a team October 8, 2025 20:46
@mial-odoo mial-odoo marked this pull request as ready for review October 8, 2025 20:57
@Felicious Felicious requested review from a team and removed request for a team October 8, 2025 21:02
@StraubCreative StraubCreative self-requested a review October 8, 2025 22:24
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes here.
I will push up the fixes in a moment and we can pass to l10n doc review, one moment...

Comment on lines 88 to 90
.. seealso::
Payroll modules are available here :doc:Mexican Payroll
<../../hr/payroll/payroll_localizations/mexico>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing backticks in the :doc: hyperlink
  • Grammar (otherwise it would show up as Payroll modules are available here Mexican Payroll
Suggested change
.. seealso::
Payroll modules are available here :doc:Mexican Payroll
<../../hr/payroll/payroll_localizations/mexico>
.. seealso::
Payroll module information is available here :doc:`here
<../../hr/payroll/payroll_localizations/mexico>`

Comment on lines 123 to 124
:doc:Mexican Payroll signing and configurations
<../../hr/payroll/payroll_localizations/mexico>
Copy link
Contributor

@StraubCreative StraubCreative Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue.
Later: this section would be better formatted as a list with a proper heading.

Suggested change
:doc:Mexican Payroll signing and configurations
<../../hr/payroll/payroll_localizations/mexico>
:doc:`Mexican Payroll signing and configurations
<../../hr/payroll/payroll_localizations/mexico>`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image is not compressed

Previous commits ended up with a little less info than intended so this PR adds two things:

Fixes the missing picture in #14582
And adds references to #14767
@StraubCreative StraubCreative force-pushed the 19.0-image-and-payroll-changes-mial branch from 08da0f0 to 017cbfe Compare October 9, 2025 12:58
@StraubCreative StraubCreative changed the title [IMP] Change image and add payroll references [IMP] l10n_mx: change image and add payroll references Oct 9, 2025
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks pass now ✅

On to you @odoo/localizations-doc-review , a quick 10 line PR for l10n_mx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants