Cleanup local variables in electronBuilder configs

ojasjadhav2 · Feb 11, 2022 · 86a8fbd · 86a8fbd
1 parent 481bb3d
commit 86a8fbd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/config/electronBuilder/electronBuilder.ghactions.config.js b/config/electronBuilder/electronBuilder.ghactions.config.js
@@ -1,12 +1,10 @@
 const baseElectronBuilderConfig = require('./electronBuilder.local.config');
 
-const isStagingBuild = process.env.NODE_ENV === 'staging';
-
 module.exports = {
     ...baseElectronBuilderConfig,
     publish: [{
         provider: 's3',
-        bucket: isStagingBuild ? 'staging-expensify-cash' : 'expensify-cash',
+        bucket: process.env.NODE_ENV === 'staging' ? 'staging-expensify-cash' : 'expensify-cash',
         channel: 'latest',
     }],
     afterSign: './desktop/notarize.js',

diff --git a/config/electronBuilder/electronBuilder.local.config.js b/config/electronBuilder/electronBuilder.local.config.js
@@ -1,6 +1,6 @@
 const ENVIRONMENT = require('../../src/CONST/ENVIRONMENT');
 
-const isStagingBuild = process.env.NODE_ENV === 'staging';
+const isStaging = process.env.NODE_ENV === 'staging';
 
 /**
  * The basic app configurations for the production and staging Electron builds,
@@ -13,11 +13,11 @@ module.exports = {
     productName: 'New Expensify',
     extraMetadata: {
         main: './desktop/main.js',
-        electronEnvironment: isStagingBuild ? ENVIRONMENT.STAGING : ENVIRONMENT.PRODUCTION,
+        electronEnvironment: isStaging ? ENVIRONMENT.STAGING : ENVIRONMENT.PRODUCTION,
     },
     mac: {
         category: 'public.app-category.finance',
-        icon: isStagingBuild ? './desktop/icon-stg.png' : './desktop/icon.png',
+        icon: isStaging ? './desktop/icon-stg.png' : './desktop/icon.png',
         hardenedRuntime: true,
         entitlements: 'desktop/entitlements.mac.plist',
         entitlementsInherit: 'desktop/entitlements.mac.plist',