Finish addressing comments

desktop/main.js

@@ -395,10 +395,6 @@ const mainWindow = (() => {
             }
 
             ipcMain.on(ELECTRON_EVENTS.LOCALE_UPDATED, (event, updatedLocale) => {
-                if (preferredLocale === updatedLocale) {
-                    return;
-                }
-
                 // Store the old locale so we can hide/remove these items after adding/showing the new ones.
                 const outdatedLocale = preferredLocale;
                 preferredLocale = updatedLocale;

src/libs/Localize/LocaleListener/index.desktop.js

@@ -1,20 +1,11 @@
 import ELECTRON_EVENTS from '../../../../desktop/ELECTRON_EVENTS';
 import BaseLocaleListener from './BaseLocaleListener';
 
-const connect = (callback) => {
-    BaseLocaleListener.connect((val) => {
-    	callback(val);
-
-    	// Send the updated locale to the Electron main process
-    	window.electron.send(ELECTRON_EVENTS.LOCALE_UPDATED, val);
-    });
-};
+const connect = () => {
     // Send the updated locale to the Electron main process
     BaseLocaleListener.connect(val => window.electron.send(ELECTRON_EVENTS.LOCALE_UPDATED, val));
 };
 
-const LocaleListener = {
-    listenForLocaleChanges,
+export default {
+    connect,
 };
-
-export default LocaleListener;

src/libs/Localize/LocaleListener/index.js

@@ -1,11 +1,5 @@
 import BaseLocaleListener from './BaseLocaleListener';
 
-const listenForLocaleChanges = () => {
-    BaseLocaleListener.connect(() => {});
+export default {
+    connect: BaseLocaleListener.connect,
 };
-
-const LocaleListener = {
-    listenForLocaleChanges,
-};
-
-export default LocaleListener;

src/libs/Localize/index.js

@@ -9,7 +9,7 @@ import LocaleListener from './LocaleListener';
 import BaseLocaleListener from './LocaleListener/BaseLocaleListener';
 
 // Listener when an update in Onyx happens so we use the updated locale when translating/localizing items.
-LocaleListener.listenForLocaleChanges();
+LocaleListener.connect();
 
 /**
  * Return translated string for given locale and phrase