Skip to content

Commit

Permalink
Merge pull request Automattic#18887 from Automattic/release/reader/co…
Browse files Browse the repository at this point in the history
…nversations-staging

Reader: Release conversations to staging, expand flags
  • Loading branch information
blowery authored Oct 16, 2017
2 parents cc33170 + 87ddaf8 commit b8413b0
Show file tree
Hide file tree
Showing 5 changed files with 46 additions and 20 deletions.
38 changes: 22 additions & 16 deletions client/reader/conversations/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,31 @@ import page from 'page';
/**
* Internal dependencies
*/
import config from 'config';
import { conversations, conversationsA8c } from './controller';
import { initAbTests, preloadReaderBundle, sidebar, updateLastRoute } from 'reader/controller';

export default function() {
page(
'/read/conversations',
preloadReaderBundle,
updateLastRoute,
initAbTests,
sidebar,
conversations
);
if ( config.isEnabled( 'reader/conversations' ) ) {
page(
'/read/conversations',
preloadReaderBundle,
updateLastRoute,
initAbTests,
sidebar,
conversations
);

page(
'/read/conversations/a8c',
preloadReaderBundle,
updateLastRoute,
initAbTests,
sidebar,
conversationsA8c
);
page(
'/read/conversations/a8c',
preloadReaderBundle,
updateLastRoute,
initAbTests,
sidebar,
conversationsA8c
);
} else {
page( '/read/conversations', '/' );
page( '/read/conversations/a8c', '/' );
}
}
7 changes: 6 additions & 1 deletion config/desktop.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
"facebook_api_key": "249643311490",
"discover_logged_out_redirect_url": "/",
"rebrand_cities_prefix": "rebrandcitiessite",
"support_locales": [ "en", "es", "pt-br" ],
"support_locales": [
"en",
"es",
"pt-br"
],
"features": {
"ad-tracking": true,
"always_use_logout_url": true,
Expand Down Expand Up @@ -75,6 +79,7 @@
"reader/following-intro": true,
"reader/full-errors": false,
"reader/search": true,
"reader/conversations": false,
"resume-editing": true,
"republicize": false,
"rubberband-scroll-disable": false,
Expand Down
7 changes: 6 additions & 1 deletion config/horizon.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@
"facebook_api_key": "249643311490",
"discover_logged_out_redirect_url": "https://discover.wordpress.com",
"rebrand_cities_prefix": "rebrandcitiestestsite",
"support_locales": [ "en", "es", "pt-br" ],
"support_locales": [
"en",
"es",
"pt-br"
],
"features": {
"ad-tracking": false,
"apple-pay": false,
Expand Down Expand Up @@ -82,6 +86,7 @@
"press-this": true,
"preview-layout": true,
"reader": true,
"reader/conversations": false,
"reader/following-intro": true,
"reader/following-manage-refresh": true,
"reader/nesting-arrow": true,
Expand Down
7 changes: 6 additions & 1 deletion config/production.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
"discover_logged_out_redirect_url": "https://discover.wordpress.com",
"facebook_app_id": "2373049596",
"rebrand_cities_prefix": "rebrandcitiessite",
"support_locales": [ "en", "es", "pt-br" ],
"support_locales": [
"en",
"es",
"pt-br"
],
"features": {
"ad-tracking": true,
"apple-pay": true,
Expand Down Expand Up @@ -86,6 +90,7 @@
"publicize-preview": true,
"push-notifications": true,
"reader": true,
"reader/conversations": false,
"reader/following-intro": true,
"reader/following-manage-refresh": true,
"reader/full-errors": false,
Expand Down
7 changes: 6 additions & 1 deletion config/stage.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@
"facebook_api_key": "249643311490",
"discover_logged_out_redirect_url": "https://discover.wordpress.com",
"rebrand_cities_prefix": "rebrandcitiestestsite",
"support_locales": [ "en", "es", "pt-br" ],
"support_locales": [
"en",
"es",
"pt-br"
],
"features": {
"ad-tracking": false,
"apple-pay": true,
Expand Down Expand Up @@ -89,6 +93,7 @@
"publicize-preview": true,
"push-notifications": true,
"reader": true,
"reader/conversations": true,
"reader/following-intro": true,
"reader/following-manage-refresh": true,
"reader/full-errors": true,
Expand Down

0 comments on commit b8413b0

Please sign in to comment.