Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker-compose installation. Redis is not included yet. #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

midnight-rev
Copy link

Added docker-compose installation.
There is no support for Redis yet, but it will be included in a near future.

@Jetrom17
Copy link

Jetrom17 commented Nov 8, 2024

Hi @midnight-rev

I noticed your recent comment about adding Docker Compose installation and mentioning that there is currently no support for Redis in the project. However, I see that the project is using the redis==5.0.5 package, which implies that Redis functionality is already integrated to some extent.

Could you clarify how your pull request aligns with the existing Redis usage in the project? Are you planning to enhance the current Redis implementation, or is there a specific reason for stating that Redis support is not available? Additionally, since the project does not utilize Docker, how do you envision the integration of Docker Compose affecting the current setup?

Thank you.

@midnight-rev
Copy link
Author

Olá @Jetrom17,
No caso, quis dizer que minha implementação do Docker Compose não contempla o serviço Redis, que necessitará de implementação posterior. Os demais serviços, como o postgresql, estão disponíveis e funcionais. Apesar do projeto utilizar o pacote redis, acredito ser necessário ter um servidor Redis para atender as requisições.

A atual implementação do Docker Compose se alinha com o projeto nos serviços utilizados e portas mapeadas, exceto o Redis. O projeto, até onde testei, está funcional, mas com essa falta do Redis, acredito que possamos testar mais. Talvez seja interessante pegar o conteúdo do PR e implementar o Redis no Docker Compose para não termos nenhum problema futuro.

Sobre o projeto como um todo, produzi o Docker Compose de forma a não prejudicar a estrutura atual do projeto, logo a instalação padrão da plataforma fora do docker deve funcionar sem problemas.

Copy link

@Jetrom17 Jetrom17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Para mim está ok. Configuração está bem feita até então para funcionamento do Docker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants