Merge pull request tsenart#187 from tsenart/parameterise-title

Parameterise plot title in NewPlotReporter
olleolleolle · May 25, 2016 · dbb7ee1 · dbb7ee1
2 parents 438b19f + 3af77ad
commit dbb7ee1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/lib/reporters.go b/lib/reporters.go
@@ -105,9 +105,9 @@ func NewJSONReporter(m *Metrics) Reporter {
 // NewPlotReporter returns a Reporter that writes a self-contained
 // HTML page with an interactive plot of the latencies of Requests, built with
 // http://dygraphs.com/
-func NewPlotReporter(rs *Results) Reporter {
+func NewPlotReporter(title string, rs *Results) Reporter {
 	return func(w io.Writer) (err error) {
-		_, err = fmt.Fprintf(w, plotsTemplateHead, asset(dygraphs), asset(html2canvas))
+		_, err = fmt.Fprintf(w, plotsTemplateHead, title, asset(dygraphs), asset(html2canvas))
 		if err != nil {
 			return err
 		}
@@ -140,7 +140,7 @@ func NewPlotReporter(rs *Results) Reporter {
 			buf = buf[:0]
 		}
 
-		_, err = w.Write([]byte(plotsTemplateTail))
+		_, err = fmt.Fprintf(w, plotsTemplateTail, title)
 		return err
 	}
 }
@@ -149,7 +149,7 @@ const (
 	plotsTemplateHead = `<!doctype html>
 <html>
 <head>
-  <title>Vegeta Plots</title>
+  <title>%s</title>
 </head>
 <body>
   <div id="latencies" style="font-family: Courier; width: 100%%; height: 600px"></div>
@@ -162,7 +162,7 @@ const (
     [`
 	plotsTemplateTail = `],
     {
-      title: 'Vegeta Plot',
+      title: '%s',
       labels: ['Seconds', 'ERR', 'OK'],
       ylabel: 'Latency (ms)',
       xlabel: 'Seconds elapsed',

diff --git a/lib/reporters_test.go b/lib/reporters_test.go
@@ -20,7 +20,7 @@ func BenchmarkPlotReporter(b *testing.B) {
 			rs[i].Error = "Error"
 		}
 	}
-	rep := NewPlotReporter(&rs)
+	rep := NewPlotReporter("Vegeta Plot", &rs)
 	// Start benchmark
 	b.ReportAllocs()
 	b.StartTimer()

diff --git a/report.go b/report.go
@@ -61,7 +61,7 @@ func report(reporter, inputs, output string) error {
 		rep, report = vegeta.NewJSONReporter(&m), &m
 	case "plot":
 		var rs vegeta.Results
-		rep, report = vegeta.NewPlotReporter(&rs), &rs
+		rep, report = vegeta.NewPlotReporter("Vegeta Plot", &rs), &rs
 	case "hist":
 		if len(reporter) < 6 {
 			return fmt.Errorf("bad buckets: '%s'", reporter[4:])