-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Apparently the Firefox on Android API doesn't support setIcon, so it crashes basically the whole core functionality. So if we're on Android, just skip that part. This fixes #22. I don't have Android so I can't test this fix. Hopefully it works.
- Loading branch information
Showing
2 changed files
with
15 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
"manifest_version": 2, | ||
"name": "Monastery", | ||
"version": "1.3.1", | ||
"version": "1.3.2", | ||
"applications": { | ||
"gecko": { | ||
"id": "[email protected]", | ||
|
@omivore
Hi, shouldn't it be a
if (info.os != "android")
instead?Your commit message states "So if we're on Android, just skip that part.". Now the icon change happens only on Android