Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Improve default functions existence with conditions #3754

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 3, 2025

Work towards #3742

Description

Improves the compilation (desugaring in particular), to support co-existence of default functions and function conditions.
Similar to pre/post conditions, default functions are also flattened.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Feb 3, 2025
@SupunS SupunS force-pushed the supun/improve-default-funcs branch from 64afc44 to a550727 Compare February 3, 2025 23:59
@SupunS SupunS marked this pull request as ready for review February 4, 2025 00:00
@SupunS SupunS requested a review from turbolent as a code owner February 4, 2025 00:00
@SupunS SupunS requested a review from jsproz February 4, 2025 00:00
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

bbq/vm/test/vm_test.go Outdated Show resolved Hide resolved
Base automatically changed from supun/compiler-result-variable to feature/compiler February 5, 2025 16:35
Copy link

github-actions bot commented Feb 5, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 9de8b2b
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS
Copy link
Member Author

SupunS commented Feb 5, 2025

@turbolent Can you maybe have another look? Particularly the last two commits 🙏

@SupunS SupunS requested a review from turbolent February 5, 2025 18:28
@SupunS SupunS merged commit 4f9641f into feature/compiler Feb 5, 2025
9 checks passed
@SupunS SupunS deleted the supun/improve-default-funcs branch February 5, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants