chore: remove pre-release-hook #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakedev9999
requested review from
mattsse,
emhane,
refcell and
clabby
as code owners
fakedev9999
force-pushed
the
taehoon/remove-pre-release-hook
branch
from
140e3c7 to
9433aac
Compare
refcell
approved these changes
Feb 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OP Succinct, we need to be able to generate a reproducible ELF (RISC-V binary) of the program, so that rollups using OP Succinct are able to refer to the canonical program. This is similar to the reproducible prestate builds for FPVM's that OP will use.
One issue we've noticed is that there's something in maili that's causing inconsistent builds. I saw this changelog.sh which emits timestamp and thought it might be the cause. I'm not really confident with the root cause of inconsistent builds, but when I removed the pre-release-hook from release.toml, the issue went away.