Skip to content

Commit

Permalink
syscall: unskip TestDirentRepeat on freebsd
Browse files Browse the repository at this point in the history
TestDirentRepeat fails on FreeBSD 11, but seems to pass on newer
versions. Go 1.18 is the last release to support FreeBSD 11 per
https://golang.org/doc/go1.18#freebsd and there are no FreeBSD 11
builders anymore. Thus unskip TestDirentRepeat to verify the issue is
indeed fixed on FreeBSD 12 and later.

For golang#31416

Change-Id: I189ef06719ff830ffe2e402c74a75874c9e5b97b
Reviewed-on: https://go-review.googlesource.com/c/go/+/393618
Trust: Tobias Klauser <[email protected]>
Run-TryBot: Tobias Klauser <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
  • Loading branch information
tklauser committed Mar 18, 2022
1 parent adfee1e commit 3d19e8d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/syscall/dirent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,6 @@ func TestDirentRepeat(t *testing.T) {
if size < 1024 {
size = 1024 // DIRBLKSIZ, see issue 31403.
}
if runtime.GOOS == "freebsd" {
t.Skip("need to fix issue 31416 first")
}
}

// Make a directory containing N files
Expand Down

0 comments on commit 3d19e8d

Please sign in to comment.