Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResourceWarning in Wandb and Update README.md #8103

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

hhaAndroid
Copy link
Collaborator

@hhaAndroid hhaAndroid commented Jun 1, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  • If the wandb version is lower than 0.12.10, the wandb.log will always print a ResourceWarning.
  • Update README

Modification

Add wandb version judgment logic

BC-breaking (Optional)

None

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #8103 (25ddfe6) into dev (3b24fdd) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

❗ Current head 25ddfe6 differs from pull request most recent head 5f8ed6a. Consider uploading reports for the commit 5f8ed6a to get more accurate results

@@            Coverage Diff             @@
##              dev    #8103      +/-   ##
==========================================
- Coverage   64.18%   64.17%   -0.02%     
==========================================
  Files         361      361              
  Lines       29514    29524      +10     
  Branches     5018     5019       +1     
==========================================
+ Hits        18945    18946       +1     
- Misses       9566     9575       +9     
  Partials     1003     1003              
Flag Coverage Δ
unittests 64.14% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/hook/wandblogger_hook.py 14.69% <20.00%> (+0.22%) ⬆️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 87.35% <0.00%> (-2.30%) ⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py 73.68% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b24fdd...5f8ed6a. Read the comment docs.

@hhaAndroid hhaAndroid requested review from ZwwWayne and jbwang1997 June 1, 2022 07:16
README.md Outdated Show resolved Hide resolved
@hhaAndroid hhaAndroid requested review from jbwang1997 and ZwwWayne June 1, 2022 07:40
Copy link
Collaborator

@jbwang1997 jbwang1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 51ad7cb into open-mmlab:dev Jun 1, 2022
@vansin
Copy link
Collaborator

vansin commented Jun 2, 2022

Could wandb give some discount for mmdetection user to Subscriptions, and support the Alipay to pay? #3737

ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
* add hint in wandb

* update readme

* update readme

* update hint of wandb
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
* add hint in wandb

* update readme

* update readme

* update hint of wandb
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
* add hint in wandb

* update readme

* update readme

* update hint of wandb
@hhaAndroid hhaAndroid deleted the wandb_fix branch July 19, 2022 07:02
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
* add hint in wandb

* update readme

* update readme

* update hint of wandb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants