Coverity Fixes for coll/tuned and coll/han/alltoallv #13187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 24e6d8e: coll/han: Fix Error-Case
e689a3a: coll/tuned: Sanitize NCOMSIZES during file read
2f9d1d2: coll/tuned: Correct bound-check
7fc5ab0: opal/util/json: Remove an extraneous check
c832fe2: coll/tuned: Prevent memory leak during tuning-file...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
jsquyres
reviewed
Apr 15, 2025
During a failed json tuning file read, it was possible to leak some json structures. Explicitly destroy them all on any error path. Fixes Coverity issues 1646446, 1646447, 1646441, and 1643439 Signed-off-by: Luke Robison <[email protected]>
Fixes Coverity Issue 1646442. Signed-off-by: Luke Robison <[email protected]>
Correct bounds-check on collective id, which was previously off by one. Fixes Coverity issues 1646445, 16464444, and 1646440. Signed-off-by: Luke Robison <[email protected]>
Addresses Coverity 1646443 Signed-off-by: Luke Robison <[email protected]>
When the initial gather fails, don't attempt to free uninitialized memory. Fixes Coverity 1645391 and 1645370 Signed-off-by: Luke Robison <[email protected]>
jsquyres
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of small fixes for problems that Coverity identified. These only apply to main and don't need backporting.