Skip to content

use-mpi-f08: Fix type of target_disp in get_accumulate prototype #13308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

N00byKing
Copy link

DISP causes the module file to be generated with integer(4) type, which then causes compilation failure as it does not match the expected integer(kind=mpi_address_kind) parameters.

The correct type should be AINT, which allows for the proper generation of the module file.
This also matches the rget_accumulate prototype.

Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

db829d1: use-mpi-f08: Fix type of target_disp in get_accumu...

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@hppritcha
Copy link
Member

This change is correct. Thanks! @N00byKing you need to sign off on your commit.

See if these instructions help

git commit --amend --no-edit -s

Copy link
Member

@hppritcha hppritcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix git commit with signature before merging, otherwise looks good.

@N00byKing
Copy link
Author

Thanks for the quick review! However, I think I already fixed the sign-off issue? Or did that go wrong?

@hppritcha
Copy link
Member

Its correct now, I was just doing my message while you pushed the update. Just waiting on the Nvidia CI to pass now.

@janjust
Copy link
Contributor

janjust commented Jun 17, 2025

bot:restart

@hppritcha hppritcha merged commit 18163f5 into open-mpi:main Jun 17, 2025
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants