Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove hads document server #2240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhopman
Copy link
Contributor

@rhopman rhopman commented Jan 14, 2025

Description

Proposal to remove hads, a document server that seems to be abandoned and has dependencies with vulnerabilities.

Personally, I don't see a need for a document server in the project, but if other people do we should look for one that is actively maintained.

Removing hads instantly resolves 5 high and 2 moderate vulnerabilities.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@rhopman rhopman marked this pull request as draft January 14, 2025 16:16
@rhopman
Copy link
Contributor Author

rhopman commented Jan 14, 2025

I had to add @fortawesome/fontawesome-free (version 6), since hads had a dependency on font-awesome (version 4) that was actually used in the application. For backward compatibility with version 4, node_modules/@fortawesome/fontawesome-free/css/v4-shims.css is added to angular.json.

@rhopman rhopman marked this pull request as ready for review January 14, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant