Skip to content

docs: clarify usage of name and instructions fields in README #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Hafiz-Muhammad-Umar12
Copy link

This pull request improves the documentation by clarifying the difference between the name and instructions parameters in the Agent constructor.
These small additions help new users better understand how to define their agent’s identity and behavior.

README.md Outdated
@@ -168,6 +168,13 @@ print(result.final_output)

(_For Jupyter notebook users, see [hello_world_jupyter.ipynb](examples/basic/hello_world_jupyter.ipynb)_)

### Note on `name` vs `instructions`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think having a new section for this on README is the best way to tell this. How about adding a simple line comment to the above code snippet?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixit

@seratch seratch added the documentation Improvements or additions to documentation label Jul 31, 2025
@seratch seratch changed the title docs: clarify usage of name and instructions fields in Agent constructor Fix agent docs docs: clarify usage of name and instructions fields in README Jul 31, 2025
@MuhammadHamidRaza
Copy link
Contributor

it's soo great because instruction is optional and name is required it's soo great idea i also want to do this add

@Hafiz-Muhammad-Umar12 Hafiz-Muhammad-Umar12 marked this pull request as draft August 2, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants