Skip to content

docs: clarify ToolsToFinalOutputResult docstrings #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MuhammedSuhaib
Copy link

  • Reworded is_final_output docstring for clarity.
  • Made rules for final_output explicit:
    • Must be non-None and match output_type when is_final_output=True.
    • Must be None when is_final_output=False.
  • No functional changes, docs only.

@seratch
Copy link
Member

seratch commented Aug 24, 2025

Thanks for the suggestion, but I don't think the current one is so bad. Let me skip the change this time.

@seratch seratch closed this Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants