fix: making input_file's filename optional in code for supporting non-OpenAI models #1839
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ant31
changed the title
seratch
changed the title
seratch
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
For gpt* models, the server already handles missing filename errors, making the current client-side validation redundant.
Thanks, this makes sense. This code is used by LiteLLM integration too, so this client-side validation would be a blocker for some models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For input_file the
filenameparameter was recently made required in #1513.This conflicts with many models outside of OpenAI, which do not require it.
This PR makes
filenameoptional again to improve compatibility across the ecosystem.For gpt* models, the server already handles missing filename errors, making the current client-side validation redundant.