Support a callable model #312
Open
+59
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
This PR is stale because it has been open for 10 days with no activity. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
seratch
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
LGTM; @rm-openai do you have any concerns to have this enhancement?
rm-openai
approved these changes
Jun 27, 2025
|
@liorheber so sorry this PR got missed. This looks good, but has some conflicts. If you're able to update, happy to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enhances the Agent class by allowing models to be specified as string, Model object, or callable.
This mirrors the flexibility already available for system prompts.
Key Features
Why This Matters
This change makes the Agent class more versatile, allowing dynamic model selection based on context, which is especially useful for complex workflows.
Assurance
All tests, linting, and type-checking pass.
Resolves #310