Fix circled command #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @compor, this is super nice. Thank you. Two comments:
|
|
@tobiasgrosser will do and ping when I get around to it! |
|
updated |
|
@tobiasgrosser I've incorporated your feedback |
|
@math-fehr can you do a full review and then see if this can be merged. |
|
Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
\circledcircles are uneven in size #41 (there is no typographic guarantee regarding the total height of letters wrt cap height and/or ascenders in a character, so the numbers are a result of experimenting with what accommodates letters with ascenders and descenders)A lot of this is based on the
\strutsuggestion here.