Bug.fix branch favoring issues #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2021 15:16
* the results of partial evaluation are now stored on an instance variable on the node, so it does not have to be recomputed with a recursive process * we no longer drop into *real* evaluation of AND/OR nodes during partial evaluation, saving another entire branch of recursion. These two changes mean the algorithm is now linear. This can be verified by adding a `puts` to the #value method of `AST::Or` and running `PERF_SIZE=<your-input-size> rspec -t perf | wc -l`, and verifying the number of times #value is called has a linear relationship to the input size number. We used the same method to verify that the previous code was superlinear (likely exponential).
|
Closing as we seem to have merged these commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.