Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update spdkrs, dependencies, nixpkgs, cargo #1767

Merged
merged 3 commits into from
Nov 4, 2024
Merged

build: update spdkrs, dependencies, nixpkgs, cargo #1767

merged 3 commits into from
Nov 4, 2024

Conversation

tiagolobocastro
Copy link
Contributor

A lot of code changes, related to clippy more strict rules.

@auto-assign auto-assign bot requested a review from dsavitskiy October 30, 2024 23:34
@tiagolobocastro
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 30, 2024
Try #1767:
74707d6
@bors-openebs-mayastor
Copy link

try

Build failed:

@tiagolobocastro
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 31, 2024
Try #1767:
0cd88b1
@bors-openebs-mayastor
Copy link

try

Build failed:

@tiagolobocastro
Copy link
Contributor Author

tiagolobocastro commented Oct 31, 2024 •
edited
Loading

Eh, looks like fs tools are too new for the CI systems:

[17548489.305395] XFS (nvme2n1): Superblock has unknown incompatible features (0x20) enabled.
[17548489.305396] XFS (nvme2n1): Filesystem cannot be safely mounted by this kernel.
[17548489.305399] XFS (nvme2n1): SB validate failed with error -22.

Looks like missing the nrext64 feature, added on 5.13 kernel

@tiagolobocastro
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 31, 2024
Try #1767:
92f688b
@bors-openebs-mayastor
Copy link

try

Build failed:

@tiagolobocastro
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 31, 2024
Try #1767:
103a988
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

👎 Rejected by too few approved reviews

Abhinandan-Purkait
Abhinandan-Purkait approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just pointed out the todos in case that was meant to be added.

io-engine/src/bdev/nvmx/controller.rs Outdated Show resolved Hide resolved
io-engine/src/bin/io-engine-client/main.rs Show resolved Hide resolved
io-engine/src/bin/io-engine-client/main.rs Show resolved Hide resolved
io-engine/src/core/fault_injection/mod.rs Show resolved Hide resolved
io-engine/src/grpc/v0/nexus_grpc.rs Show resolved Hide resolved
io-engine/src/grpc/server.rs Show resolved Hide resolved
io-engine/src/lvs/lvol_snapshot.rs Show resolved Hide resolved
io-engine/src/lvs/lvs_lvol.rs Show resolved Hide resolved
test/python/common/nvme.py Show resolved Hide resolved
@tiagolobocastro
build: update spdkrs, dependencies, nixpkgs, cargo
4a0e6f0 
A lot of code changes, related to clippy more strict rules.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
test: disable xfs feature nrext64
98cc83e 
Our CI systems predate this feature.
It's not relevant for our testing so we can disable it.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
test(bdd): make nvme controller usage more robust
f74a0cd 
Caters for when the device is /dev/nvmeX but X not the same as the controller!

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 8c3bedf into develop Nov 4, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the update branch November 4, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niladrih niladrih niladrih approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

@dsharma-dc dsharma-dc Awaiting requested review from dsharma-dc

@dsavitskiy dsavitskiy Awaiting requested review from dsavitskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagolobocastro @Abhinandan-Purkait @niladrih